Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changes to support Jakartaee10 jars and Glassfish 7 #11

Merged
merged 2 commits into from
Apr 20, 2022

Conversation

gurunrao
Copy link
Contributor

changes to support Jakartaee10 jars and Glassfish 7.

Signed-off-by: gurunandan.rao@oracle.com <gurunandan.rao@oracle.com>
@gurunrao gurunrao force-pushed the jakartaee10 branch 2 times, most recently from f340f98 to 1224eec Compare April 12, 2022 07:14
@starksm64
Copy link
Member

In the #12 PR is have reorganized the artifacts and modules to be generic, and the version reflects the GlassFish version. Once this PR is merged, I can update the master branch to use the same organization.

@starksm64 starksm64 self-requested a review April 12, 2022 12:59
pom.xml Outdated Show resolved Hide resolved
glassfish-common/pom.xml Outdated Show resolved Hide resolved
@starksm64
Copy link
Member

starksm64 commented Apr 12, 2022

@gurunrao #12 is on a new glassfish6 branch, so it won't have any conflicts.

@hantsy
Copy link
Member

hantsy commented Apr 12, 2022

Hope to bring the embedded Glassfish adapter back in this version.

@gurunrao gurunrao force-pushed the jakartaee10 branch 2 times, most recently from 3ee0256 to 27597de Compare April 12, 2022 16:56
@starksm64
Copy link
Member

starksm64 commented Apr 12, 2022

If I try to build your fork with SE 11, I'm seeing that the org.glassfish.hk2:hk2-locator:jar:3.0.0-M1 artifact cannot be found:

[ERROR] Failed to execute goal on project arquillian-glassfish6-common: Could not resolve dependencies for project org.jboss.arquillian.container:arquillian-glassfish6-common:jar:1.0.0.Final-SNAPSHOT: org.glassfish.hk2:hk2-locator:jar:3.0.0-M1
was not found in https://jakarta.oss.sonatype.org/content/repositories/staging/ during a previous attempt. This failure was
cached in the local repository and resolution is not reattempted until the update interval of jakarta-nexus-staging has
elapsed or updates are forced -> [Help 1]

@gurunrao
Copy link
Contributor Author

If I try to build your fork with SE 11, I'm seeing that the org.glassfish.hk2:hk2-locator:jar:3.0.0-M1 artifact cannot be found:

[ERROR] Failed to execute goal on project arquillian-glassfish6-common: Could not resolve dependencies for project org.jboss.arquillian.container:arquillian-glassfish6-common:jar:1.0.0.Final-SNAPSHOT: org.glassfish.hk2:hk2-locator:jar:3.0.0-M1
was not found in https://jakarta.oss.sonatype.org/content/repositories/staging/ during a previous attempt. This failure was
cached in the local repository and resolution is not reattempted until the update interval of jakarta-nexus-staging has
elapsed or updates are forced -> [Help 1]

currently not able to reproduce the issue, attaching logs

Signed-off-by: gurunandan.rao@oracle.com <gurunandan.rao@oracle.com>
@gurunrao
Copy link
Contributor Author

@gurunrao
Copy link
Contributor Author

@starksm64 - org.glassfish.hk2:hk2-locator:jar:3.0.0-M1 artifact cannot be found error is not seen in local setup or CI.

@gurunrao
Copy link
Contributor Author

@starksm64 - Let me know if the PR can be merged, as review comments are not open?

@starksm64 starksm64 merged commit 9e2f3de into arquillian:master Apr 20, 2022
@starksm64
Copy link
Member

I merged it. We still need to get the main branch CI config updated and working.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants