Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Store list of installed extensions and image vendor to image and not to BSP #7182

Merged
merged 3 commits into from
Sep 8, 2024

Conversation

igorpecovnik
Copy link
Member

@igorpecovnik igorpecovnik commented Sep 7, 2024

Description

Revert #7156

Checklist:

  • My code follows the style guidelines of this project
  • My changes generate no new warnings

@igorpecovnik igorpecovnik requested a review from a team as a code owner September 7, 2024 09:57
@github-actions github-actions bot added size/small PR with less then 50 lines Framework Framework components labels Sep 7, 2024
@igorpecovnik igorpecovnik added 11 Milestone: Fourth quarter release Needs review Seeking for review and removed Framework Framework components labels Sep 7, 2024
alexl83 added a commit to alexl83/build that referenced this pull request Sep 7, 2024
by double quoting `${ENABLE_EXTENSIONS}` we make sure framework doesn't crash during initrd build
while interpreting a possible space-separated second extension from config file or command line

Might be an alternative to PR armbian#7182

Bonus: this also saves armbian-add-overlay from same behavior
@igorpecovnik igorpecovnik added the Ready to merge Reviewed, tested and ready for merge label Sep 8, 2024
@igorpecovnik igorpecovnik merged commit 7aa89f3 into main Sep 8, 2024
17 checks passed
@igorpecovnik igorpecovnik deleted the store_extensions branch September 8, 2024 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
11 Milestone: Fourth quarter release Needs review Seeking for review Ready to merge Reviewed, tested and ready for merge size/small PR with less then 50 lines
Development

Successfully merging this pull request may close these issues.

2 participants