lib/functions/bsp/armbian-bsp-cli-deb.sh: add variable quoting
#7184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
by double quoting `${ENABLE_EXTENSIONS}` we make sure framework doesn't crash during initrd build
while interpreting a possible space-separated second extension from config file or command line
Might be an alternative to PR armbian#7182
Bonus: this also saves armbian-add-overlay from same behavior
github-actions
bot
added
size/small
alexl83
changed the title
lib/functions/bsp/armbian-bsp-cli-deb.sh: fix variable quotinglib/functions/bsp/armbian-bsp-cli-deb.sh: add variable quoting
|
We need to keep extensions at image level, not BSP. |
|
Yeah. |
|
Cool, closing :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
by double quoting
${ENABLE_EXTENSIONS}we make sure framework doesn't crash during initrd build while interpreting a possible space-separated second extension from config file or command lineMight be an alternative to PR #7182
Bonus: this also saves armbian-add-overlay from same behavior
Checklist: