Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(build): re-add #4127 and steps to verify image pull #4219

Merged
merged 3 commits into from
Oct 5, 2020
Merged

chore(build): re-add #4127 and steps to verify image pull #4219

merged 3 commits into from
Oct 5, 2020

Conversation

lippertmarkus
Copy link
Member

@lippertmarkus lippertmarkus commented Oct 5, 2020

Like discussed the pull error from #4216 seems to be caused by a rare corner-case where the Docker Hub failed somehow when the image was pushed. I don't think a specific change broke it as pulling the latest-images did work even before the revert of #4127.

Example run: https://github.com/lippertmarkus/argo/actions/runs/289933647

You may also want to cherry-pick this to release-2.11.

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
  • The title of the PR is (a) conventional, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234".
  • My organization is added to USERS.md.
  • I've signed the CLA.
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My builds are green. Try syncing with master if they are not.

@alexec alexec merged commit 0879067 into argoproj:master Oct 5, 2020
alexcapras pushed a commit to alexcapras/argo that referenced this pull request Nov 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants