-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(build): Pre-push temporary manifest with linux/amd64. Fixes #4062 #4127
Conversation
Is there any risk we're swapping reliability and ease of maintenance for speed? |
The only risk I see is that there may be more Windows or ARM64 users in the future and some of them might rely on the images also being available as soon as a new version is released. Another idea would be to automate the release process and run it after images are built. Then the time for image builds wouldn't matter anymore. |
OK. Lets merge and see what happens. |
Next master build: https://github.com/argoproj/argo/actions/runs/278832139 |
…nifest later (argoproj#4127)" This reverts commit c8eed1f.
…ater (argoproj#4127) Signed-off-by: Alex Capras <alexcapras@gmail.com>
…goproj#4219) Signed-off-by: Alex Capras <alexcapras@gmail.com>
This is pre-pushing a temporary manifest to DockerHub referencing the linux/amd64 images right after those are built so we can release earlier without having to wait for the long-running arm64 image builds. After all images finished building the temporary manifest is overwritten with a new one with references to all images for amd64, arm64 and windows.
Details:
argoproj/argoexec:v2.11-linux-amd64
- this will only take around 6minutesargoproj/argoexec:v2.11
referencing onlyargoproj/argoexec:v2.11-linux-amd64
for nowargoproj/argoexec:v2.11
now referencingargoproj/argoexec:v2.11-linux-amd64
,argoproj/argoexec:v2.11-linux-arm64
,argoproj/argoexec:v2.11-windows
Example run: https://github.com/lippertmarkus/argo/actions/runs/270351664
Checklist:
"fix(controller): Updates such and such. Fixes #1234"
.