Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: Fix build by providing clean repo inside Docker #3848

Merged
merged 18 commits into from
Aug 23, 2020
Merged

ci: Fix build by providing clean repo inside Docker #3848

merged 18 commits into from
Aug 23, 2020

Conversation

dgiebert
Copy link
Contributor

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
  • The title of the PR is (a) conventional, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234".
  • I've signed the CLA.
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My builds are green. Try syncing with master if they are not.
  • My organization is added to USERS.md.

@alexec Sorry for providing such bad PRs, I always tested with the check commented out as my repo locally was never clean.

Dominic Giebert and others added 18 commits August 19, 2020 07:28
Follow docs on build + push
59fbd3a
Build in fork
35f074a
Remove package
8d96370
Only build amd64 + arm64
a8fbfb0
Revert remote build
aeb070a
@simster7
fix: Consider all children of TaskGroups in DAGs (#3740)
a929e86
@rbreeze
feat(ui): add node memoization information to node summary view (#3741)
fe45feb
@simonfrey
docs: memory base amount denominator documentation
0472b90
@crunchtime-ali
ci: static files not being built with Homebrew and dirty binary. Fixes …
7aec0f4 
…#3769 (#3801)
@alexec
test: Skip TestStopBehavior and TestRetryOmit (#3822)
c5f43d8
@sarabala1979
fix(docs): Add Entrypoint Cron Backfill example Fixes #3807 (#3814)
580b4e9
@sarabala1979
fix: Carry over ownerReferences from resubmitted workflow. Fixes #3818 (
97ab016 
#3820)
@cmontemuino
fix(docs): Amend link to the Workflow CRD (#3828)
7ae9f56
@rbreeze
fix(ui): crash when workflow node has no memoization info (#3839)
a5b27df
Fix merge conflict
0be6df4
Change dockerignore back
dc4f500
Dont copy out of location
a240964
Merge remote-tracking branch 'upstream/master' into fix-build
e603432
@dgiebert dgiebert changed the title Ci: Fix build by providing clean repo inside Docker ci: Fix build by providing clean repo inside Docker Aug 22, 2020
@alexec alexec merged commit a821c6d into argoproj:master Aug 23, 2020
@lippertmarkus lippertmarkus mentioned this pull request Sep 18, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexec alexec alexec approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@dgiebert @alexec @simster7 @rbreeze @simonfrey @crunchtime-ali @sarabala1979 @cmontemuino