Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Amend link to the Workflow CRD. Fixes #3827 #3828

Merged
merged 1 commit into from
Aug 20, 2020
Merged

docs: Amend link to the Workflow CRD. Fixes #3827 #3828

merged 1 commit into from
Aug 20, 2020

Conversation

cmontemuino
Copy link
Contributor

@cmontemuino cmontemuino commented Aug 20, 2020 •
edited
Loading

Workflow CRD's link is pointing to ClusterWorkflowTemplate CRD

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
  • The title of the PR is (a) conventional, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234".
  • I've signed the CLA.
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My builds are green. Try syncing with master if they are not.
  • My organization is added to USERS.md.

@cmontemuino
fix(docs): Amend link to the Workflow CRD
ca51828 
Workflow CRD's link is pointing to ClusterWorkflowTemplate CRD
@CLAassistant
Copy link

CLAassistant commented Aug 20, 2020 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@cmontemuino cmontemuino marked this pull request as ready for review August 20, 2020 06:24
@cmontemuino cmontemuino marked this pull request as draft August 20, 2020 07:37
@cmontemuino cmontemuino marked this pull request as ready for review August 20, 2020 07:38
@alexec alexec linked an issue Aug 20, 2020 that may be closed by this pull request
withItems incorrect type in full CRD #3578
Closed
@alexec alexec changed the title fix(docs): Amend link to the Workflow CRD docs: Amend link to the Workflow CRD. Fixes #3578 Aug 20, 2020
@alexec alexec merged commit a2f54da into argoproj:master Aug 20, 2020
@alexec alexec changed the title docs: Amend link to the Workflow CRD. Fixes #3578 docs: Amend link to the Workflow CRD. Aug 20, 2020
@alexec alexec linked an issue Aug 20, 2020 that may be closed by this pull request
wrong link in ide-setup #3827
Closed
@alexec alexec changed the title docs: Amend link to the Workflow CRD. docs: Amend link to the Workflow CRD. Fixes #3827 Aug 20, 2020
@alexec alexec removed a link to an issue Aug 20, 2020
withItems incorrect type in full CRD #3578
Closed
@alexec
Copy link
Contributor

alexec commented Aug 20, 2020

Thank you!

@cmontemuino cmontemuino deleted the patch-1 branch August 21, 2020 06:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexec alexec alexec approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

wrong link in ide-setup
3 participants
@cmontemuino @CLAassistant @alexec