Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: fix operator metric tests #12730

Merged
merged 1 commit into from
Mar 2, 2024
Merged

test: fix operator metric tests #12730

merged 1 commit into from
Mar 2, 2024

Conversation

blkperl
Copy link
Contributor

@blkperl blkperl commented Mar 1, 2024 •
edited by agilgur5
Loading

Motivation

Tests were passing when 33ad82f / #12702 was merged but new PRs are failing unit tests now.

Modifications

Changed the getMetricStringValue helper to call the String() function

Verification

Unit tests will pass

@blkperl
test: Fix operator metric tests
56df1b0 
Signed-off-by: william.vanhevelingen <william.vanhevelingen@acquia.com>
@blkperl blkperl force-pushed the fix_operator_metric_tests branch from 770ec65 to 56df1b0 Compare March 1, 2024 21:51
@blkperl blkperl marked this pull request as ready for review March 1, 2024 21:59
@blkperl blkperl changed the title test: Fix operator metric tests test: fix operator metric tests Mar 1, 2024
agilgur5
agilgur5 approved these changes Mar 2, 2024
View reviewed changes
Copy link

@agilgur5 agilgur5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for tracking this down!

@agilgur5 agilgur5 merged commit 7286d49 into argoproj:main Mar 2, 2024
29 of 30 checks passed
@agilgur5 agilgur5 added area/build Build or GithubAction/CI issues area/upstream This is an issue with an upstream dependency, not Argo itself labels Mar 2, 2024
@jswxstw
Copy link
Member

jswxstw commented Mar 4, 2024

@blkperl It still fails.

2024-03-04T02:29:55.3602389Z --- FAIL: TestBasicMetric (0.02s)
2024-03-04T02:29:55.3602655Z     operator_metrics_test.go:73: 
2024-03-04T02:29:55.3603491Z         	Error Trace:	/home/runner/work/argo-workflows/argo-workflows/workflow/controller/operator_metrics_test.go:73
2024-03-04T02:29:55.3604578Z         	Error:      	"label:{name:\"name\"  value:\"random-int\"}  gauge:{value:-9.223372036854776e+09}" does not contain "label:{name:\"name\" value:\"random-int\"} gauge:{value:"
2024-03-04T02:29:55.3604849Z         	Test:       	TestBasicMetric

@jswxstw jswxstw mentioned this pull request Mar 4, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agilgur5 agilgur5 agilgur5 approved these changes

Assignees
No one assigned
Labels
area/build Build or GithubAction/CI issues area/upstream This is an issue with an upstream dependency, not Argo itself
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@blkperl @jswxstw @agilgur5