chore(deps): bump prometheus dependencies #12702
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agilgur5
added
type/dependencies
agilgur5
reviewed
Feb 27, 2024
There was a problem hiding this comment.
Not sure if you noticed (since you marked this as ready), but CI is still failing unit tests and an E2E test suite here
fixes argoproj#12429, fixes argoproj#12272, fixes argoproj#11957 Signed-off-by: william.vanhevelingen <william.vanhevelingen@acquia.com>
|
@agilgur5 should be all set now. I had to downgrade to go 1.21 because go 1.22 has issues |
terrytangyuan
approved these changes
Feb 29, 2024
|
@blkperl what is the issue with go 1.22? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: william.vanhevelingen william.vanhevelingen@acquia.com
fixes #12429, fixes #12272, fixes #11957
Motivation
Modifications
Verification