Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: support managing cluster with multiple argocd instances and annotation based tracking (#20222) #20488

Merged
merged 1 commit into from
Oct 22, 2024

fix: support managing cluster with multiple argocd instances and anno…

015abb2
Select commit
Loading
Failed to load commit list.
Merged

fix: support managing cluster with multiple argocd instances and annotation based tracking (#20222) #20488

fix: support managing cluster with multiple argocd instances and anno…
015abb2
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Oct 21, 2024 in 1s

54.97% (-0.02%) compared to 8340e1e

View this Pull Request on Codecov

54.97% (-0.02%) compared to 8340e1e

Details

Codecov Report

Attention: Patch coverage is 54.16667% with 55 lines in your changes missing coverage. Please review.

Project coverage is 54.97%. Comparing base (8340e1e) to head (015abb2).
Report is 3 commits behind head on release-2.13.

Files with missing lines Patch % Lines
util/kube/kube.go 38.88% 9 Missing and 2 partials ⚠️
controller/state.go 60.00% 6 Missing and 2 partials ⚠️
util/webhook/webhook.go 12.50% 6 Missing and 1 partial ⚠️
util/argo/argo.go 25.00% 5 Missing and 1 partial ⚠️
util/argo/resource_tracking.go 64.70% 4 Missing and 2 partials ⚠️
controller/sync.go 33.33% 3 Missing and 1 partial ⚠️
controller/cache/cache.go 50.00% 2 Missing and 1 partial ⚠️
reposerver/cache/cache.go 81.25% 3 Missing ⚠️
server/application/application.go 40.00% 2 Missing and 1 partial ⚠️
util/settings/settings.go 50.00% 2 Missing and 1 partial ⚠️
... and 1 more
Additional details and impacted files 
@@               Coverage Diff                @@
##           release-2.13   #20483      +/-   ##
================================================
- Coverage         54.98%   54.97%   -0.02%     
================================================
  Files               320      320              
  Lines             54514    54601      +87     
================================================
+ Hits              29976    30017      +41     
- Misses            21972    22007      +35     
- Partials           2566     2577      +11

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov