Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: support managing cluster with multiple argocd instances and annotation based tracking (#20222) #20488

Merged
merged 1 commit into from
Oct 22, 2024

Conversation

alexmt
Copy link
Collaborator

@alexmt alexmt commented Oct 22, 2024

Cherry-picks #20222 into 2.13

…tation based tracking (argoproj#20222)

Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>
@alexmt alexmt requested review from a team as code owners October 22, 2024 07:53
Copy link
Member

@nitishfy nitishfy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Although the CI checks are failing, why did we approve these changes?

@alexmt
Copy link
Collaborator Author

alexmt commented Oct 22, 2024

@nitishfy unfortunately Check changes to generated code step always fails in release branch. This is something we need to fix

@alexmt alexmt merged commit 435989c into argoproj:release-2.13 Oct 22, 2024
35 of 39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants