Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BLO-934 chore: add generics to 2fa fetchers #1972

Merged
merged 4 commits into from
Apr 3, 2023
Merged

BLO-934 chore: add generics to 2fa fetchers #1972

merged 4 commits into from
Apr 3, 2023

Conversation

simonheys
Copy link
Collaborator

Issue / feature description

Adds generics to fetchers used by 2fa in preparation for some additional api calls

Changes

  • add generics to fetchers used by 2fa
  • add types where these are also used in other code
  • allow functions to infer return types where possible

Checklist

  • Rebased to the last commit of the target branch (or merged)
  • Code self-reviewed
  • Code self-tested
  • Tests updated (if needed)
  • All tests are passing locally

@simonheys simonheys force-pushed the fix/BLO-934-2fa-generics branch from 99ce46a to d45d7cb Compare March 29, 2023 17:47
@github-actions
Copy link

Builds for local testing

@simonheys simonheys force-pushed the fix/BLO-934-2fa-generics branch from d45d7cb to cbc548f Compare March 29, 2023 17:53
@github-actions
Copy link

Builds for local testing

@github-actions
Copy link

Builds for local testing

@simonheys simonheys force-pushed the fix/BLO-934-2fa-generics branch from cbc548f to 26ab79a Compare March 30, 2023 10:52
@simonheys simonheys marked this pull request as ready for review March 30, 2023 10:52
@github-actions
Copy link

Builds for local testing

@simonheys simonheys added the 2fa label Mar 30, 2023
@simonheys simonheys force-pushed the fix/BLO-934-2fa-generics branch from 26ab79a to 4749c90 Compare March 31, 2023 13:01
@github-actions
Copy link

Builds for local testing

@simonheys simonheys force-pushed the fix/BLO-934-2fa-generics branch from 4749c90 to e56be39 Compare March 31, 2023 13:10
@github-actions
Copy link

Builds for local testing

@simonheys simonheys force-pushed the fix/BLO-934-2fa-generics branch from e56be39 to ee03b76 Compare March 31, 2023 14:52
@github-actions
Copy link

Builds for local testing

@github-actions
Copy link

github-actions bot commented Apr 3, 2023

Builds for local testing

@sonarqubecloud
Copy link

sonarqubecloud bot commented Apr 3, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
1.8% 1.8% Duplication

@gergold gergold merged commit 45131f6 into develop Apr 3, 2023
@gergold gergold deleted the fix/BLO-934-2fa-generics branch April 3, 2023 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bluecco bluecco bluecco approved these changes

@gergold gergold gergold approved these changes

Assignees
No one assigned
Labels
2fa
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@simonheys @gergold @bluecco