Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BLO-934 fix: 2fa time skew #1981

Merged
merged 2 commits into from
Apr 3, 2023
Merged

BLO-934 fix: 2fa time skew #1981

merged 2 commits into from
Apr 3, 2023

Conversation

simonheys
Copy link
Collaborator

@simonheys simonheys commented Mar 30, 2023 •
edited
Loading

Issue / feature description

Use server time when creating jwt

Changes

  • add time endpoint
  • determine time skew with server
  • calculate expected backend time using skew

Checklist

  • Rebased to the last commit of the target branch (or merged)
  • Code self-reviewed
  • Code self-tested
  • Tests updated (if needed)
  • All tests are passing locally

@simonheys simonheys marked this pull request as ready for review March 30, 2023 13:43
@simonheys simonheys changed the title Fix/blo 934 2fa time skew BLO-934 fix: 2fa time skew Mar 30, 2023
@bluecco
Copy link
Contributor

bluecco commented Mar 30, 2023 •
edited
Loading

I was doing something similar in a shared folder for webwallet
I will add this as soon as it will be merged in develop

@simonheys simonheys added the 2fa label Mar 30, 2023
@simonheys simonheys force-pushed the fix/BLO-934-2fa-generics branch from 26ab79a to 4749c90 Compare March 31, 2023 13:01
@simonheys simonheys force-pushed the fix/BLO-934-2fa-time-skew branch from 3a72bb5 to 3ed54ad Compare March 31, 2023 13:01
@simonheys simonheys force-pushed the fix/BLO-934-2fa-generics branch from 4749c90 to e56be39 Compare March 31, 2023 13:10
@simonheys simonheys force-pushed the fix/BLO-934-2fa-time-skew branch from 3ed54ad to 20b315c Compare March 31, 2023 13:11
@simonheys simonheys force-pushed the fix/BLO-934-2fa-generics branch from e56be39 to ee03b76 Compare March 31, 2023 14:52
@simonheys simonheys force-pushed the fix/BLO-934-2fa-time-skew branch from 20b315c to 3e78103 Compare March 31, 2023 14:53
@gergold gergold merged commit a53d2de into fix/BLO-934-2fa-generics Apr 3, 2023
@gergold gergold deleted the fix/BLO-934-2fa-time-skew branch April 3, 2023 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@diegodelrieu diegodelrieu diegodelrieu approved these changes

@bluecco bluecco bluecco approved these changes

Assignees
No one assigned
Labels
2fa
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@simonheys @bluecco @diegodelrieu @gergold