Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using lru-cache: ^10.4.3 #205

Merged
merged 5 commits into from
Sep 9, 2024

Conversation

RobinTail
Copy link
Contributor

@RobinTail RobinTail commented Sep 8, 2024

Fixes #204 compatibility to Node 18.18+

Copy link

changeset-bot bot commented Sep 8, 2024

🦋 Changeset detected

Latest commit: 1f419ac

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@arethetypeswrong/core Patch
@arethetypeswrong/cli Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@RobinTail RobinTail marked this pull request as ready for review September 8, 2024 05:48
Copy link
Collaborator

@andrewbranch andrewbranch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don’t want to enable skipLibCheck. Instead, can you pnpm patch lru-cache and apply this fix to the types? isaacs/node-lru-cache@5ed947d

@RobinTail
Copy link
Contributor Author

can you pnpm patch lru-cache

✅ Done, @andrewbranch

@andrewbranch
Copy link
Collaborator

Thanks!

@andrewbranch andrewbranch merged commit 556dbc8 into arethetypeswrong:main Sep 9, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

lru-cache dependency breaks the declared Node.js compatibility
2 participants