Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lru-cache dependency breaks the declared Node.js compatibility #204

Closed
RobinTail opened this issue Sep 7, 2024 · 5 comments · Fixed by #205
Closed

lru-cache dependency breaks the declared Node.js compatibility #204

RobinTail opened this issue Sep 7, 2024 · 5 comments · Fixed by #205

Comments

@RobinTail
Copy link
Contributor

RobinTail commented Sep 7, 2024

Adding this line:

Broke the Node.js compatibility of the package.

error lru-cache@11.0.1: The engine "node" is incompatible with this module. Expected version "20 || >=22". Got "18.18.0"

Commit: 33abbdb

The package Node.js compatibility is declared as >= 18, but that dependency is not compatible with v18.

CC @andrewbranch

@RobinTail
Copy link
Contributor Author

Suggesting to use lru-cache v10, since it was only v11 that recently dropped Node 18 according to the changelog:
https://github.com/isaacs/node-lru-cache/blob/main/CHANGELOG.md

@andrewbranch
Copy link
Collaborator

I think I’ll probably drop support for v18 myself. I feel like supporting only active LTS versions is fine for a CI tool.

@RobinTail
Copy link
Contributor Author

RobinTail commented Sep 8, 2024

Node 18.18+ is LTS (maintenance LTS) at the moment, @andrewbranch
I believe it's important to keep its compatibility up to the EOL (May 2025)

image

image

@RobinTail
Copy link
Contributor Author

RobinTail commented Sep 8, 2024

Dear @andrewbranch ,

you're making a very important tool for the community and I believe you can drop Node 18 in May 2025 (EOL is 2025-04-30), but at the moment it needs a little care: please review my PR, it works fine with previous version of lru-cache.

#205

@RobinTail
Copy link
Contributor Author

RobinTail commented Sep 8, 2024

The workaround for yarn

  "resolutions": {
    "@arethetypeswrong/**/lru-cache": "^10.4.3"
  },

for npm that would be overrides I presume.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants