Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dont hang on SASL logins #122

Merged
merged 2 commits into from
May 31, 2022
Merged

Dont hang on SASL logins #122

merged 2 commits into from
May 31, 2022

Conversation

gtrak
Copy link
Contributor

@gtrak gtrak commented May 31, 2022

SASL is currently unsupported but has become the default in common postgres 14 setups. Instead of a hang, we can throw a real error until it can be supported.

@gtrak gtrak force-pushed the dont-hang-sasl branch from df0ff56 to 1836164 Compare May 31, 2022 16:05
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.2%) to 66.837% when pulling 1836164 on dont-hang-sasl into fc9647e on master.

@gtrak gtrak merged commit de8a45d into master May 31, 2022
mseri pushed a commit to ocaml/opam-repository that referenced this pull request May 31, 2022
…, pgx_lwt_mirage, pgx_lwt, pgx_async and pgx (2.1)

CHANGES:

### Breaking changes

* Missing SASL authentication impl provides an error instead of hanging (arenadotio/pgx#122).
* pgx_lwt_mirage now requires conduit 2.3 instead of 2.2 (arenadotio/pgx#117).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants