Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Mirage dependencies #117

Merged
merged 4 commits into from
Mar 10, 2022
Merged

Conversation

yomimono
Copy link
Contributor

@yomimono yomimono commented Mar 8, 2022

This makes pgx_lwt_mirage build with modern Mirage dependencies. It builds on #116 .

@gtrak
Copy link
Contributor

gtrak commented Mar 9, 2022

@yomimono are you done with all the changes you plan to do here? We're ready to check if we can integrate it. Are the Ci tests failing because of your changes?

#!/bin/bash -eo pipefail
cd unikernel && opam exec -- mirage configure -t spt

                                  (cd _build/default && /home/opam/.opam/4.11/bin/ocamlc.opt -w @1..3@5..28@30..39@43@46..47@49..57@61..62-40 -strict-sequence -strict-formats -short-paths -keep-locs -warn-error -A -g -bin-annot -I .config.eobjs/byte -I /home/opam/.opam/4.11/lib/astring -I /home/opam/.opam/4.11/lib/bos -I /home/opam/.opam/4.11/lib/cmdliner -I /home/opam/.opam/4.11/lib/domain-name -I /home/opam/.opam/4.11/lib/fmt -I /home/opam/.opam/4.11/lib/fpath -I /home/opam/.opam/4.11/lib/functoria -I /home/opam/.opam/4.11/lib/functoria-runtime -I /home/opam/.opam/4.11/lib/functoria/app -I /home/opam/.opam/4.11/lib/ipaddr -I /home/opam/.opam/4.11/lib/logs -I /home/opam/.opam/4.11/lib/lwt -I /home/opam/.opam/4.11/lib/macaddr -I /home/opam/.opam/4.11/lib/mirage -I /home/opam/.opam/4.11/lib/mirage-runtime -I /home/opam/.opam/4.11/lib/ocamlgraph -I /home/opam/.opam/4.11/lib/ptime -I /home/opam/.opam/4.11/lib/ptime/clock/os -I /home/opam/.opam/4.11/lib/result -I /home/opam/.opam/4.11/lib/rresult -I /home/opam/.opam/4.11/lib/seq -I /home/opam/.opam/4.11/lib/stdlib-shims -no-alias-deps -opaque -o .config.eobjs/byte/config.cmo -c -impl config.ml)
File "config.ml", line 61, characters 8-13:
61 |       $ stack
             ^^^^^
Error: This expression has type stackv4v6 impl
       but an expression was expected of type stackv4 impl
       Type stackv4v6 is not compatible with type stackv4 
mirage: unknown option '-t'.     

@yomimono
Copy link
Contributor Author

yomimono commented Mar 9, 2022

Yes, I hadn't realized there was a sample unikernel, which I need to make a few more edits to. I'll at-mention you once the tests are passing.

@yomimono yomimono force-pushed the update-mirage-deps branch from 8e30bac to a0eb23a Compare March 9, 2022 22:14
@yomimono
Copy link
Contributor Author

yomimono commented Mar 9, 2022

@gtrak Passing now and ready for review whenever someone has the time. Thanks!

@gtrak
Copy link
Contributor

gtrak commented Mar 10, 2022

Ok, this looks good. I'll land it, and I guess we can cut a release or something later.

@gtrak gtrak self-requested a review March 10, 2022 16:40
@gtrak gtrak merged commit 3f2c0fc into arenadotio:master Mar 10, 2022
@gtrak gtrak mentioned this pull request Mar 10, 2022
mseri pushed a commit to ocaml/opam-repository that referenced this pull request May 31, 2022
…, pgx_lwt_mirage, pgx_lwt, pgx_async and pgx (2.1)

CHANGES:

### Breaking changes

* Missing SASL authentication impl provides an error instead of hanging (arenadotio/pgx#122).
* pgx_lwt_mirage now requires conduit 2.3 instead of 2.2 (arenadotio/pgx#117).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants