Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed different method signatures for NETFRAMEWORK and NETSTANDARD2_0 #338

Merged
merged 1 commit into from
Feb 10, 2024
Merged

Removed different method signatures for NETFRAMEWORK and NETSTANDARD2_0 #338

merged 1 commit into from
Feb 10, 2024

Conversation

Ergamon
Copy link
Contributor

@Ergamon Ergamon commented Feb 10, 2024

The CallerArgumentExpressionAttribute also works for older versions than NETSTANDARD2_1.

So I changed the compiler directives accordingly and removed all differing signatures.

@github-actions GitHub Actions
Copy link

Code Coverage

Package Line Rate Branch Rate Complexity Health
Ardalis.GuardClauses 47% 92% 287 ❌
Summary 47% (270 / 571) 92% (120 / 130) 287 ❌

@ardalis ardalis merged commit 901616c into ardalis:main Feb 10, 2024
1 check passed
@ardalis
Copy link
Owner

ardalis commented Feb 10, 2024

Thanks! I'll try and get this published this week.

@canro91 canro91 mentioned this pull request Jul 3, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ardalis ardalis ardalis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Ergamon @ardalis @GeraldLx