-
Notifications
You must be signed in to change notification settings - Fork 530
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replacing flit #1655
Replacing flit #1655
Conversation
I've verified that both |
@Torxed I didn't realize this happened until now that I was trying to merge in master into the pyparted branch. Isn't this sort of a move backwards? Wouldn't it rather make sense to use |
Until we do, the move backwards is just a simplification which would hopefully be less prone to regressions and issues as it's Anything specific we'd like from poetry? I think we evaluated poetry in the very beginning :) |
It makes sense to have them all operating from the same set of tools. Some issues I have experienced with |
Maybe I'm missing something but do we actually need a AFAIK setuptools is not able to install dependencies only, so it will be (a bit) more cumbersome for devs to get started as they have to dig out the required packages from the toml and then install them. Setup with Poetry
Build project
Install project
:) |
PR Description:
As discussed in pypa/flit#522 and #832 the future of flit doesn't appear appealing to me and others.
So while we're ahead, I'm replacing
flit
with justsetuptools
and relying on it to build for us.This allows for external dependencies as well via:
or
setup.cfg
And if it's a build-only specific dependency put it in:
A good reference on how to include the profiles and stuff was from here: https://godatadriven.com/blog/a-practical-guide-to-setuptools-and-pyproject-toml/
Tests and Checks