-
Notifications
You must be signed in to change notification settings - Fork 530
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support external dependencies #1478
Conversation
Interesting, I'll have a gander at this :) Would this solve pypa/flit#509? :) |
@Torxed I haven't tried that actually, I'll test that tomorrow |
I do remember though that in the reworked profile PR #1434, I had removed the links since they caused some issues in various IDEs and I wasn't sure about the usage of them. |
@Torxed I run it on my local this is the resulting structure
when running master with
it results in
which seems to be the same |
I'll take this as a reference #1477 (comment) :) Anything I can help here with further? |
Let me check some things first, especially around packaging :) |
dependencies = [ | ||
"pyparted==3.12.0", | ||
"simple-term-menu==1.5.0", | ||
] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we update the PR to only include this change, after merging upstream master
into this PR branch, I think we're good to merge this.
I've replaced flit
and the build process in #1655
This work has all been merged with another PR so I'll close this PR |
This should enable support for external dependencies, fix #1447
Since the project is using
flit
as a install/build/publish utility, we should no longer need the legacysetup.{py,cfg}
files since everything is managed in thepyproject.toml
.Now,
flit
has some downsides unfortunately, like it can't install "only" dependencies from a pyproject.toml file and it also doesn't allow to specify a target installation directory.Since https://wiki.archlinux.org/title/Python_package_guidelines#Installation_methods mentions that installation has to be done into a temporary directory
flit
can't achieve this and therefore can't be used in the PKGBUILD file.Looking at other projects, a fair amount of them are using pip to install both, the dependencies and the package, into the temporary directory, so I borrowed the approach from those
I'm not an expert in the PKGBUILD space so @Torxed please advise if this is a bad idea :)