test-helpers: re-organize, update to web3 1.0, and add utilities from dao-templates, react-boilerplate #43
Conversation
| ? await blockOrPromise() | ||
| : await blockOrPromise | ||
| } catch (error) { | ||
| if (isGeth(ctx)) { |
There was a problem hiding this comment.
This part is a bit sketchy and taken from dao-templates.
I think this should still work on an Istanbul context, but I won't know until we try 😄.
In any case, my philosophy here is to ensure we can use the same utilities regardless of ganache or a real chain and we can certainly come back to this to fix it if it doesn't end up working well.
| bn(actual).toString(), | ||
| bn(expected).toString(), |
There was a problem hiding this comment.
Bear in mind this may not work for different versions of BN, I prefer being flexible here. Calling .toString() to any type of BN seems safer to me.
| function normalizeArg(arg) { | ||
| if (isBN(arg)) { |
There was a problem hiding this comment.
There were some versions of web3-utils that do not include isBN.
There was a problem hiding this comment.
This is likely from the 0.2 series—I think since the 1.0 series started, and they moved over the bn.js, this has existed.
| return arg.toString() | ||
| } else if (isAddress(arg)) { | ||
| return toChecksumAddress(arg) | ||
| } |
There was a problem hiding this comment.
Let's contemplate the case of comparing contracts with addresses: see #35 (comment)
There was a problem hiding this comment.
Oh interesting, so that's why that was there. I'll add it back!
Co-authored-by: Gabriel Garcia <gabrielpk.18@gmail.com>
| @@ -0,0 +1,13 @@ | |||
| const EMPTY_BYTES = '0x' | |||
| const ZERO_BYTES32 = | |||
| '0x0000000000000000000000000000000000000000000000000000000000000000' | |||
There was a problem hiding this comment.
Works as well! We can do so for addresses as well :).
Can you push a PR?
Replaces #30 with a more aggressive re-organization. Takes the useful utilities from
dao-templatesandaragon-react-boilerplate(fixes #28).dcda933 is the primary commit with changes to add new or refactor existing utilities.
Utilities from
@aragon/contract-helpers-testare now grouped into separate sections:root: base utilities for Ethereum-related interactionsasserts: Ethereum-related assertionsaragon-os: aragonOS-related utilitiesaragon-os/asserts: aragonOS-related assertionsIt now also includes the concept of a "configuration", shamelessly inspired by Open Zeppelin's own test helpers, that will detect the global truffle environment or allow a user to override and inject their own.
Future PRs: