Test helpers: update and align with other contract repos #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xGabi
reviewed
Jul 14, 2020
| // Sets spec id and concatenates per call | ||
| // [ 20 bytes (address) ] + [ 4 bytes (uint32: calldata length) ] + [ calldataLength bytes (payload) ] | ||
| // Defaults spec id to 1 | ||
| function encodeCallScript (actions, specId = 1) { |
There was a problem hiding this comment.
I feel like this logic doesn't belong to a test utility library and we are using it on several places already. Wonder if maybe a few of these across the stack that could belong to a small utility package?
There was a problem hiding this comment.
Maybe, but it's so small that I don't mind replicating it. At some point it may be worth taking the encode/decode utilities out from aragon.js into a separate package, e.g. @aragon/contract-toolkit.
bingen
reviewed
Jul 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the test helpers with changes from the other contract repos and updates code styles.
Pulls in all the non-contract changes from #35, except for the package restructuring, which will be done after.