Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wrapper: return original step if radspec couldn't be evaluated #298

Merged
merged 1 commit into from
Apr 30, 2019

Conversation

sohkai
Copy link
Contributor

@sohkai sohkai commented Apr 30, 2019

Oops, this wasn't being caught with the radspec refactor.

If we don't know what the function is (e.g. see example issue: aragon/aragon-cli#450), we should return an undecorated version of the step.

@sohkai sohkai requested a review from 2color April 30, 2019 17:57
@sohkai sohkai merged commit 06f60e5 into master Apr 30, 2019
@sohkai sohkai deleted the fix-radspec-missing-functions branch April 30, 2019 17:59
2color added a commit to 2color/aragon.js that referenced this pull request May 14, 2019
…th-cache

* origin/master:
  @aragon/wrapper 5.0.0-rc.5
  fix: add back name and identifer to describe script (aragon#299)
  wrapper: return original step if radspec couldn't be evaluated (aragon#298)
  @aragon/wrapper 5.0.0-rc.3
  wrapper: handle intent baskets (aragon#286)
  @aragon/wrapper 5.0.0-rc.3
  Wrapper: add artifacts for aragonPM apps (aragon#273)
  Wrapper: override fetched app info with on-chain values (aragon#288)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant