wrapper: handle intent baskets #286
Conversation
| async getTransactionPathForIntentBasket (intentBasket, { checkMode = 'all' } = {}) { | ||
| // Get transaction paths for entire basket | ||
| const intentsToCheck = | ||
| checkMode === 'all' |
There was a problem hiding this comment.
When would checkMode all be used?
The only usage of it uses single:
https://github.com/aragon/aragon/blob/98bf8de6309ad747c7cea1c92e4ffe08823e296c/src/components/Upgrade/UpgradeOrganizationPanel.js#L69-L72
There was a problem hiding this comment.
Is that because the intentBasket coming from the client will have the same path (they all call setApp)?
There was a problem hiding this comment.
all isn't used yet, since our only use case is calling the same function, but in the future when you might be including very different transactions (e.g. withdraw from Finance and burn a token at the same time, see aragon/client#363), it'll be important to use all to check that all the actions can actually be performed together.
|
I tested the direct transaction scenario on an org with an account that has the Moreover, the activity item didn't render the correct description: |
Yes... debugging this with the client now. The problem is that if you have direct access, the only thing we can do is ask you to sign multiple transactions (and this bit isn't working well yet). |
…nd handle their failures
…heck for 0.7 upgrade
|
The logic for how radspec is handled as been completely refactored into its own module. In the future we may think about letting users of This also strips out a few unnecessary details out of the intents:
|
|
Update: Working with latest master of aragon/client#732 |
|
@2color Are you using the current head of aragon/client#732? It should be handling the removal of |
…th-cache * origin/master: @aragon/wrapper 5.0.0-rc.5 fix: add back name and identifer to describe script (aragon#299) wrapper: return original step if radspec couldn't be evaluated (aragon#298) @aragon/wrapper 5.0.0-rc.3 wrapper: handle intent baskets (aragon#286) @aragon/wrapper 5.0.0-rc.3 Wrapper: add artifacts for aragonPM apps (aragon#273) Wrapper: override fetched app info with on-chain values (aragon#288)
Has a few kinks to work out, but works for single-transaction organization upgrades.