Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add integration tests for dao token new #904

Merged
merged 3 commits into from
Nov 19, 2019
Merged

Conversation

kernelwhisperer
Copy link
Contributor

🦅 Pull Request

🚨 Test instructions

✔️ PR Todo

  • Include links to related issues/PRs
  • Update unit tests for this change
  • Update the relevant documentation
  • Clear dependencies on other modules that have to be released before merging this

@codecov
Copy link

codecov bot commented Nov 12, 2019

Codecov Report

Merging #904 into develop will increase coverage by 0.55%.
The diff coverage is 85.71%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #904      +/-   ##
===========================================
+ Coverage     10.3%   10.85%   +0.55%     
===========================================
  Files           91       93       +2     
  Lines         2397     2404       +7     
===========================================
+ Hits           247      261      +14     
+ Misses        2150     2143       -7
Impacted Files Coverage Δ
...ages/aragon-cli/scripts/setup-integration-tests.js 100% <100%> (ø)
...s/aragon-cli/scripts/teardown-integration-tests.js 75% <75%> (ø)
packages/aragon-cli/src/util.js 46.15% <0%> (+5.59%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 23bddf0...de746e6. Read the comment docs.

@kernelwhisperer kernelwhisperer marked this pull request as ready for review November 13, 2019 14:21
@0xGabi 0xGabi added the 🛠️ toolkit Toolkit for accessing Aragon utilities programmatically. label Nov 14, 2019
Copy link
Contributor

@0xGabi 0xGabi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing work @0x6431346e 🔥

I'm still a bit hesitant to call this type of tests e2e. I recognize that you are right and even as they are more like an e2e in nature we might want to call them integrations 🤷‍♂️

@0xGabi
Copy link
Contributor

0xGabi commented Nov 18, 2019

Hey Daniel I broke the CI and I was not able to fix it yet, it seems the aragen devchain is not running as a background process

@kernelwhisperer kernelwhisperer force-pushed the e2e-tests-v2 branch 2 times, most recently from b432c7a to 7807b96 Compare November 19, 2019 13:26
@macor161 macor161 self-requested a review November 19, 2019 15:12
@kernelwhisperer kernelwhisperer changed the title Add e2e tests within the repo Add integration tests Nov 19, 2019
@kernelwhisperer kernelwhisperer changed the title Add integration tests Add integration tests for dao token new Nov 19, 2019
Copy link
Contributor

@macor161 macor161 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect for me! Great job @0x6431346e !! 💯 Anyone knows why the linter is failing in the github actions?

@kernelwhisperer
Copy link
Contributor Author

Perfect for me! Great job @0x6431346e !! Anyone knows why the linter is failing in the github actions?

It was using the old workflow file, it should work fine now after I re-based.

@kernelwhisperer kernelwhisperer merged commit 0574c8b into develop Nov 19, 2019
@kernelwhisperer kernelwhisperer deleted the e2e-tests-v2 branch November 19, 2019 15:34
@0xGabi 0xGabi added the SDK v7 label Nov 21, 2019
@0xGabi 0xGabi mentioned this pull request Nov 21, 2019
43 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🛠️ toolkit Toolkit for accessing Aragon utilities programmatically.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants