-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add integration tests for dao token new
#904
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #904 +/- ##
===========================================
+ Coverage 10.3% 10.85% +0.55%
===========================================
Files 91 93 +2
Lines 2397 2404 +7
===========================================
+ Hits 247 261 +14
+ Misses 2150 2143 -7
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing work @0x6431346e 🔥
I'm still a bit hesitant to call this type of tests e2e
. I recognize that you are right and even as they are more like an e2e in nature we might want to call them integrations 🤷♂️
Hey Daniel I broke the CI and I was not able to fix it yet, it seems the aragen devchain is not running as a background process |
b432c7a
to
7807b96
Compare
1f4efbd
to
de746e6
Compare
dao token new
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfect for me! Great job @0x6431346e !! 💯 Anyone knows why the linter is failing in the github actions?
It was using the old workflow file, it should work fine now after I re-based. |
🦅 Pull Request
🚨 Test instructions
✔️ PR Todo