Add integration tests for dao token new (#904)

packages/aragon-cli/package.json

@@ -15,6 +15,8 @@
     "build:watch": "npm run build -- -- --watch",
     "lint": "eslint src test",
     "lint:fix": "npm run lint -- --fix",
+    "pretest": "node scripts/setup-integration-tests.js & sleep 5",
+    "posttest": "node scripts/teardown-integration-tests.js",
     "test": "ava --verbose",
     "test:watch": "ava --watch",
     "test:coverage": "nyc --all --reporter text --reporter text-summary --reporter lcovonly  npm run test"
@@ -112,6 +114,7 @@
     "eslint-plugin-prettier": "^3.0.0",
     "eslint-plugin-promise": "^4.0.1",
     "eslint-plugin-standard": "^4.0.0",
+    "kill-port": "^1.6.0",
     "nyc": "^14.1.1",
     "prettier": "^1.15.3",
     "proxyquire": "^2.1.0",
@@ -161,7 +164,9 @@
     ],
     "env": {
       "test": {
-        "plugins": [ "istanbul" ]
+        "plugins": [
+          "istanbul"
+        ]
       }
     }
   },

packages/aragon-cli/scripts/setup-integration-tests.js

@@ -0,0 +1,7 @@
+const execa = require('execa')
+
+// execa('npx', ['ganache-cli'], {
+execa('npx', ['aragen', 'start'], {
+  stdout: process.stdout
+})
+  .catch(() => 'Cannot set up the devchain')

packages/aragon-cli/scripts/teardown-integration-tests.js

@@ -0,0 +1,5 @@
+const killProcessOnPort = require('kill-port')
+
+killProcessOnPort('8545')
+  .then(() => 'Process killed on 8545')
+  .catch(() => 'Cannot kill the process on 8545')

packages/aragon-cli/test/integration/test-utils.js

@@ -0,0 +1,13 @@
+import Web3 from 'web3'
+
+export const isValidTxHash = txHash => /^0x([A-Fa-f0-9]{64})$/.test(txHash)
+export const isAddress = Web3.utils.isAddress
+
+export const getLocalWeb3 = async () => {
+  const web3 = new Web3(
+    new Web3.providers.HttpProvider(`http://localhost:8545`)
+  )
+  const connected = await web3.eth.net.isListening()
+  if (!connected) throw new Error('Web3 connection failed')
+  return web3
+}

packages/aragon-cli/test/integration/token.test.js

@@ -0,0 +1,39 @@
+import test from 'ava'
+import sinon from 'sinon'
+import * as tokenLib from '../../src/lib/token'
+import { isAddress, isValidTxHash, getLocalWeb3 } from './test-utils'
+
+test.beforeEach(async t => {
+  const web3 = await getLocalWeb3()
+  const accounts = await web3.eth.getAccounts()
+
+  t.context = {
+    web3,
+    accounts,
+  }
+})
+
+test.afterEach.always(() => {
+  sinon.restore()
+})
+
+test('deployMiniMeTokenFactory: should deploy the contract with the right args', async t => {
+  t.plan(5)
+  // arrange
+  const { web3, accounts } = t.context
+  // act
+  const result = await tokenLib.deployMiniMeTokenFactory(
+    web3,
+    accounts[0],
+    21,
+    () => {}
+  )
+  // assert
+  t.true(isValidTxHash(result.txHash))
+  t.true(isAddress(result.address))
+
+  const tx = await web3.eth.getTransaction(result.txHash)
+  t.snapshot(tx.input, 'the MiniMeTokenFactory bytecode is correct')
+  t.snapshot(tx.gasPrice, 'the transaction gas price is correct')
+  t.snapshot(tx.gas, 'the transaction gas is correct')
+})