Voting new styles for 0.8

[AquiGorka]

Fixes #714.

How to test

Either ask the author if the latest changes have been deployed to preview.aragon.org

or

Assuming everything is in the ~/projects directory (replace by your own).

First time

Clone this repo + Aragon client’s + aragonUI’s if not done already:

cd ~/projects
git clone git@github.com:aragon/aragon-apps.git
git clone git@github.com:aragon/aragon.git
git clone git@github.com:aragon/aragon-ui.git

Create a link for aragonUI (npm might tell you that it is already done):

cd ~/projects/aragon-ui
npm link

Getting updates

Here we are updating the branches + reinstalling the dependencies + linking aragonUI again.

cd ~/projects/aragon-ui
git checkout newstyle
git pull origin newstyle
npm install

cd ~/projects/aragon
git checkout newstyle
git pull origin newstyle
npm install
npm link @aragon/ui

cd ~/projects/aragon-apps/apps/token-manager/app
git checkout newstyle/voting
git pull origin newstyle/voting
npm install
npm link @aragon/ui

Running it

We can now start the two servers (the app + Aragon client). In one shell session (or tab in your terminal app):

cd ~/projects/aragon-apps/apps/token-manager/app
npm start

In another session (we are asking the client to load apps running locally):

cd ~/projects/aragon
env REACT_APP_ASSET_BRIDGE=local yarn start

Open http://localhost:3000/ in your browser.

[coveralls]

Coverage decreased (-0.3%) to 97.635% when pulling 4eb8404 on newstyle/voting into a4f873e on newstyle-0.8.

[AquiGorka]

Hmm, for this you could've used the usePromise hook that the inner functions rely on.

[sohkai]

Hmm yes, but usePromise()'s API is based on returning the resulting value from the promise (so you can use it) whereas we just want to cancel it here and avoid a side effect.

[AquiGorka]

Pseudo code here (this is what I was thinking):

const promise = Promise.all([canUserVotePromise, canExecutePromise, userBalancePromise])
const value = usePromise(promise, false)
setReady(value)

But yeah, there are other things that might need to be worked on.

[sohkai]

Yeah, I'm worried there might be funny things with how the state gets updated / triggered (compared to now, which is relatively obvious what happens on cancellation / updates), and to be honest usePromise() is something we should find a better abstraction for since it's kind of clunky.