Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Voting: deploy preview to now #939

Merged
merged 2 commits into from
Jul 29, 2019
Merged

Conversation

sohkai
Copy link
Contributor

@sohkai sohkai commented Jul 26, 2019

Similar to #937, allows someone to deploy to nightly-voting.aragon.org with

now --target production

@coveralls
Copy link

Coverage Status

Coverage remained the same at 98.0% when pulling af845f3 on deploy-preview-voting into 6c2654a on newstyle/voting.

Copy link
Contributor

@AquiGorka AquiGorka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️
Should I merge this directly? Everytime a release happens with aragonUI the reference should be updated no? and every time a "significant" update is pushed will this be automatic or do I've to manually deploy?

@sohkai
Copy link
Contributor Author

sohkai commented Jul 29, 2019

@AquiGorka Unfortunately as of now, this is not automatic (want to do some other things that will eventually allow us to make automatic staging deploys possible). But, once you install now's desktop app or @now/cli, you can (and should!) use the command above to deploy (assuming you've hooked up your now account properly).

The @aragon/ui version does not need to be changed if new alphas are published (they should get fetched automatically), but it is not a bad idea to keep moving it up anyway :). I've also updated the comment, it does not currently require you to link @aragon/ui, that was my mistake earlier :).

@sohkai sohkai merged commit e2157f5 into newstyle/voting Jul 29, 2019
@sohkai sohkai deleted the deploy-preview-voting branch July 29, 2019 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants