Use TokenBadge from aragonUI #857
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AquiGorka
reviewed
May 17, 2019
| @@ -79,6 +78,7 @@ class SideBar extends React.Component { | |||
| address={tokenAddress} | |||
| name={tokenName} | |||
| symbol={tokenSymbol} | |||
| networkType={network.type} | |||
There was a problem hiding this comment.
Is this needed with the new badge?
There was a problem hiding this comment.
It is needed with the new badge yes! But at some point we’ll have providers for the network the tokens in aragonUI, which will make the address the only thing needed on TokenBadge.
AquiGorka
approved these changes
May 17, 2019
MickdeGraaf
pushed a commit
to MickdeGraaf/aragon-apps
that referenced
this pull request
Jan 28, 2020
ramilexe
pushed a commit
to ConsiderItDone/aragon-apps
that referenced
this pull request
Dec 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.