Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show org token name and ticker symbol #273

Closed
john-light opened this issue Apr 19, 2018 · 7 comments
Closed

Show org token name and ticker symbol #273

john-light opened this issue Apr 19, 2018 · 7 comments
Assignees
@bpierre
Labels
app: token manager component: frontend enhancement good first issue

Comments

@john-light
Copy link
Contributor

"Token" label in Token Manager -> should this be or show the org token name and ticker symbol? It should be shown somewhere in the app anyways. (Maybe Settings app too?)
@sohkai
Copy link
Contributor

sohkai commented Aug 14, 2018

Made aragon/client#320 for showing the org name elsewhere in the wrapper.

@john-light
Copy link
Contributor Author

Ok. To be clear, this issue is about the token name and ticker symbol, not the org name.

@sohkai sohkai added the design label Aug 30, 2018
@sohkai sohkai added this to the sprint: 1.3 milestone Aug 30, 2018
@cfl0ws cfl0ws modified the milestones: sprint: 1.3, sprint: 1.2 Sep 7, 2018
@jounih
Copy link

jounih commented Sep 12, 2018

Discussed - will design token badge that has the logo and ticker in non-expanded version

@jounih
Copy link

jounih commented Sep 19, 2018 •
edited
Loading

Updated

WebApp-1366px - Tokens - token address@2x.jpg

@cfl0ws
Copy link

cfl0ws commented Sep 20, 2018

Changing back to "design: pending", as we're waiting for @jounih to complete the changes we discussed during yesterday's call.

@sohkai sohkai modified the milestones: sprint: 1.2, sprint: 1.3 Sep 27, 2018
@bpierre bpierre self-assigned this Sep 28, 2018
bpierre added a commit that referenced this issue Oct 12, 2018
@bpierre
Display the token name and symbol (fixes #273)
2599446
This was referenced Oct 16, 2018
Closed
Closed
@bpierre
Copy link
Contributor

bpierre commented Oct 16, 2018 •
edited
Loading

Waiting for TokenBadge to be implemented https://github.com/aragon/aragon-ui/issues/221

@bpierre bpierre removed this from the sprint: 1.3 milestone Oct 16, 2018
@sohkai sohkai added this to the A1 Sprint: 3.2 milestone Jan 14, 2019
@sohkai sohkai modified the milestones: A1 Sprint: 3.2, A1 Sprint: 4.1 Feb 4, 2019
@sohkai sohkai removed this from the A1 Sprint: 4.1 milestone Feb 4, 2019
@sohkai
Copy link
Contributor

sohkai commented May 18, 2019

Fixed with #857.

@sohkai sohkai closed this as completed May 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bpierre bpierre

Labels
app: token manager component: frontend enhancement good first issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@bpierre @sohkai @cfl0ws @john-light @jounih