Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Voting: fix voting copy to fit one line & add tooltip #1115

Merged
merged 2 commits into from
Apr 9, 2020
Merged

Conversation

Evalir
Copy link
Contributor

@Evalir Evalir commented Apr 9, 2020

Building over the discussion at #1110 .

Here's how it looks with the copy changes:

Screen Shot 2020-04-08 at 11 56 19 PM

Screen Shot 2020-04-08 at 11 59 22 PM

Copy link
Contributor

@sohkai sohkai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link

@dizzypaty dizzypaty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🗳

@Evalir Evalir merged commit fd126c1 into master Apr 9, 2020
@Evalir Evalir deleted the fix-voting-copy branch April 9, 2020 14:06
facuspagnuolo pushed a commit that referenced this pull request May 22, 2020
* Add voting copy suggestions on vote details

* Fix copies on vote details, add .prettierrc
ramilexe pushed a commit to ConsiderItDone/aragon-apps that referenced this pull request Dec 9, 2021
* Add voting copy suggestions on vote details

* Fix copies on vote details, add .prettierrc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants