Voting: add support / approval copy suggestion

[Evalir]

Spring cleaning 🌸, closing #1346 over at aragon/aragon.

Your affinity for fixes is apparent. I'm confident you'll find a typo there as well.

Adds suggestion for the voting copy regarding approval & support by @john-light . Maybe we want a bit more discussion around it?

Screenshots:

[dizzypaty]

LGTM ✅

[sohkai]

@Evalir Could we have a screenshot accompanying these types of changes?

Wanted to check how this looks, and whether we would prefer having a space after the > :).

[Evalir]

Ah yes, I'm actually putting up screenshots for these changes; may have missed posting these. I'll edit the original PR message to have them.

[sohkai]

Right... so in this case, we can see that the title is now overflowing into two lines and is most likely not what we'd like:

To get that character back... maybe we could rephrase to (needs >50% support) cc @dizzypaty?

[Evalir]

Seems that this would work!

But in fact, if the numbers are too big, it doesn't work at all:

To get around this, I believe we have two options:

• Remove the >
• Change the font size to be able to accommodate the characters.

[sohkai]

Another option is to drop the "support" or "quorum" from the copy, given that it's already in context due to the Box's title.

We could also add Help tooltips to explain both support and quorum, given that they are typically overloaded terms and confusing for users who have not read our definitions for them.

cc @dizzypaty

[Evalir]

This makes sense. Something like 99.62% (needs >50%)

I'd say we only need to wait for @dizzypaty 's thoughts and we can do a quick PR.

[john-light]

@Evalir while we're modifying this section's copy, could we change Relative Support % in the box's title to Support %? I'm not sure what "Relative" is supposed to mean here, and anyways AFAIK we don't call it "Relative Support" anywhere else (neither in the Permissions for this parameter nor the setup flow when first setting this parameter).

[Evalir]

I believe we can @john-light ; we indeed are not using the "relative term" anywhere else, even in the internal contract documentation.

[sohkai]

We use "relative percentage" when describing support during onboarding:

Support is the relative percentage of tokens that are required to vote “Yes” for a proposal to be approved

This was meant to contrast the absolute nature of calculating quorum (support is relative to current voters, quorum is absolute against all possible voters).

But I agree, we should be consistent with "support". Perhaps we can lift the Help tooltips directly from onboarding?