Finance: MCD DAI migration #1048
Conversation
probot-autolabeler
bot
added
app: finance
app: token manager
component: frontend
labels
| } | ||
|
|
||
| // On other networks, pretend any token with the same symbol is legit | ||
| const mainnetEquivalent = ETHER_TOKEN_VERIFIED_BY_SYMBOL.get(tokenSymbol) |
There was a problem hiding this comment.
Couldn’t that be an (minor) issue for people testing an org on rinkeby with a symbol in the list? What about doing it the other way, by having a list of test tokens by network?
There was a problem hiding this comment.
Yes... we could add an extra check to make sure that the given token address is in the list of test tokens?
In that case, it would only be our test tokens that look "legit" with icons displayed in test networks.
There was a problem hiding this comment.
we could add an extra check to make sure that the given token address is in the list of test tokens?
Done in 70d65d4.
| DAI_MAINNET_TOKEN_ADDRESS, | ||
| { symbol: 'DAI', name: 'Dai Stablecoin v1.0', decimals: '18' }, | ||
| SAI_MAINNET_TOKEN_ADDRESS, | ||
| { symbol: 'SAI', name: 'Sai Stablecoin v1.0', decimals: '18' }, |
There was a problem hiding this comment.
Good to see they fixed that in MCD DAI!
There was a problem hiding this comment.
Yes, thankfully. I still don't know how they got to that bytes32 abomination.
| @@ -44,18 +46,18 @@ export const isTokenVerified = (tokenAddress, networkType) => | |||
| ? ETHER_TOKEN_VERIFIED_ADDRESSES.has(tokenAddress.toLowerCase()) | |||
| : true | |||
|
|
|||
| export const tokenDataFallback = (tokenAddress, fieldName, networkType) => { | |||
| // The fallback list is without checksums | |||
| export const tokenDataOverride = (tokenAddress, fieldName, networkType) => { | |||
sohkai
force-pushed
the
finance-mcd-dai
branch
from
c68359e to
70d65d4
Compare
* Finance, Tokens: update verified tokens * Finance: upgrade to MCD DAI and use tokenIconUrl() for token icons * Finance: only show token icons on test networks for known test tokens
* Finance, Tokens: update verified tokens * Finance: upgrade to MCD DAI and use tokenIconUrl() for token icons * Finance: only show token icons on test networks for known test tokens
Based off #1045
tokenIconUrl()while gracefully handling testnet tokens