Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Finance: stop loading assets from chasing-coins #1101

Closed
john-light opened this issue Oct 1, 2019 · 2 comments
Closed

Finance: stop loading assets from chasing-coins #1101

john-light opened this issue Oct 1, 2019 · 2 comments
Assignees
@sohkai
Labels
app: finance bug priority: high

Comments

@john-light
Copy link
Contributor

john-light commented Oct 1, 2019 •
edited
Loading

Describe the bug
The currency logos in the finance app are not loading from the source e.g. https://chasing-coins.com/coin/logo/DAI

Screenshots

Screenshot_2019-10-01 Aragon
@john-light john-light added the bug label Oct 1, 2019
@sohkai
Copy link
Contributor

sohkai commented Oct 9, 2019 •
edited
Loading

@john-light This is mostly likely to do with an adblocker installed locally.

Not that we should really be using icons from chasing-coins.com anymore in Finance; we should be fetching via https://github.com/aragon/aragon-ui/blob/newstyle/src/utils/web3.js#L144 instead. I've updated this issue to reflect that.

The only problem preventing this from being a drop-in replacement is our testnet tokens, since we "fake" them based on their symbols.

@sohkai sohkai changed the title chasing-coins assets not loading Finance: stop loading assets from chasing-coins Oct 9, 2019
@sohkai sohkai mentioned this issue Oct 16, 2019
Closed
@sohkai sohkai self-assigned this Nov 19, 2019
@sohkai
Copy link
Contributor

sohkai commented Jan 23, 2020

Fixed in aragon/aragon-apps#1048. We now load the icons from a verified github repo (TrustWallet's).

@sohkai sohkai closed this as completed Jan 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sohkai sohkai

Labels
app: finance bug priority: high
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sohkai @john-light