-
Notifications
You must be signed in to change notification settings - Fork 212
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Voting: app paths #1029
Voting: app paths #1029
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🙌Amazing, this works really well!
Right now we still have to wait until the vote's been synced from events for the app to load the details page, but we can make it instant later with aragon/client#1163.
apps/voting/app/src/app-logic.js
Outdated
// The `ready` check prevents a vote to be selected | ||
// until the app state is fully ready. | ||
if (!ready || selectedVoteId === '-1') { | ||
const voteId = path ? voteIdFromPath(path) : NO_VOTE_ID |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thoughts on rolling up the path
check directly into voteIdFromPath()
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That’s better yes!
It is working on both mainnet and rinkeby, for example at https://rinkeby.aragon.org/#/ngo/0xc3e8deb4a85718388628b9b5758d1fb242a4d0c1/vote/1/ The API documentation is available:
Basically, use |
Requires aragon/aragon.js#405