-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integrate deep linking in the Projects app #943
Comments
@ottodevs @topocount , what changes need to be made to the Projects contract to be able to display the deep link in the radspec, specifically for the "review submission" part of the flow? E.g. the link is to the work submission of a particular user. Do we need the radspec IPFS helper to be able to somehow determine the deep link based on the IPFS hash? LOC:
|
The way you seem to propose, I guess the radspec IPFS helper would be needed to decode the The alternative approach would be start using the internal github issue numbers, that are already unique, I recently discovered about this approach and it would be really interesting to start using this, since you can decode the internal issue number from the issue id and the other way around... So the change would be start encoding the github issue number into the contract, that way we would not need to use the radspec IPFS helper for this case. |
@ottodevs I notice this issue is connected to a merged PR. Are there any more changes needed before we move this to |
Testing this in the continuous deploy DAO on December 20th 2019, everything works as expected! |
We should implement deep links for the following pages:
Reference implementations
The text was updated successfully, but these errors were encountered: