Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate deep linking in the Projects app #943

Closed
stellarmagnet opened this issue May 28, 2019 · 4 comments
Closed

Integrate deep linking in the Projects app #943

stellarmagnet opened this issue May 28, 2019 · 4 comments
Assignees
Milestone

Comments

@stellarmagnet
Copy link
Collaborator

stellarmagnet commented May 28, 2019

We should implement deep links for the following pages:

  • Project detail page
  • Review application panel (per applicant)
  • Review work panel (per submission)
  • Issues landing page (all projects shown)
    • Note: eventually we should be able to link a specific filter set
  • Settings tab

Reference implementations

@stellarmagnet stellarmagnet added this to the Sprint 19.17 milestone Jun 23, 2019
@stellarmagnet stellarmagnet removed this from the Sprint 19.19 milestone Aug 29, 2019
@stellarmagnet stellarmagnet changed the title Deep linking in aragon - integrate the solution with an existing app Integrated deep linking to support the open enterprise launch Aug 30, 2019
@stellarmagnet stellarmagnet changed the title Integrated deep linking to support the open enterprise launch Integrate deep linking in the Projects app Nov 7, 2019
@stellarmagnet
Copy link
Collaborator Author

stellarmagnet commented Dec 4, 2019

@ottodevs @topocount , what changes need to be made to the Projects contract to be able to display the deep link in the radspec, specifically for the "review submission" part of the flow? E.g. the link is to the work submission of a particular user. Do we need the radspec IPFS helper to be able to somehow determine the deep link based on the IPFS hash?

LOC:

* @notice `_approved ? 'Accept' : 'Reject'` work for issue `_issueNumber` with info: `_updatedSubmissionHash`

@stellarmagnet stellarmagnet added this to the Sprint B2 milestone Dec 4, 2019
@ottodevs
Copy link
Member

ottodevs commented Dec 6, 2019

@ottodevs @topocount , what changes need to be made to the Projects contract to be able to display the deep link in the radspec, specifically for the "review submission" part of the flow? E.g. the link is to the work submission of a particular user. Do we need the radspec IPFS helper to be able to somehow determine the deep link based on the IPFS hash?

LOC:

* @notice `_approved ? 'Accept' : 'Reject'` work for issue `_issueNumber` with info: `_updatedSubmissionHash`

The way you seem to propose, I guess the radspec IPFS helper would be needed to decode the issueId from it, because the deep-link is based on the issueId.

The alternative approach would be start using the internal github issue numbers, that are already unique, I recently discovered about this approach and it would be really interesting to start using this, since you can decode the internal issue number from the issue id and the other way around... So the change would be start encoding the github issue number into the contract, that way we would not need to use the radspec IPFS helper for this case.

@javieralaves javieralaves modified the milestones: Sprint B2, Sprint B3 Dec 16, 2019
@javieralaves
Copy link
Collaborator

@ottodevs I notice this issue is connected to a merged PR. Are there any more changes needed before we move this to Review?

@javieralaves
Copy link
Collaborator

Testing this in the continuous deploy DAO on December 20th 2019, everything works as expected!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants