Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add scanJobAnnotations to the Job instead of just the Pod #2111

Merged
merged 3 commits into from
Jun 2, 2024

Conversation

darkhelmet
Copy link
Contributor

@darkhelmet darkhelmet commented May 29, 2024

Description

The scanJobAnnotations were only added to the Pod, and not the Job, despite the name. Let's add the annotations to both places.

Related issues

Checklist

  • I've read the guidelines for contributing to this repository.
  • I've added tests that prove my fix is effective or that my feature works.
  • I've updated the documentation with the relevant information (if needed).
  • I've added usage information (if the PR introduces new options)
  • I've included a "before" and "after" example to the description (if the PR is a user interface change).

@CLAassistant
Copy link

CLAassistant commented May 29, 2024

CLA assistant check
All committers have signed the CLA.

@darkhelmet darkhelmet changed the title Add scanJobAnnotations to the Job instead of just the Pod fix: Add scanJobAnnotations to the Job instead of just the Pod May 29, 2024
@github-actions github-actions bot added the bug label May 29, 2024
@darkhelmet darkhelmet marked this pull request as ready for review May 29, 2024 16:56
@darkhelmet darkhelmet requested a review from chen-keinan as a code owner May 29, 2024 16:56
@chen-keinan
Copy link
Contributor

@darkhelmet run the following to resolve lint issues:

mage generate:all
mage generate:docs

@chen-keinan
Copy link
Contributor

@darkhelmet lgtm 🚀 thank you for the contribution

@chen-keinan chen-keinan merged commit 20a8a5b into aquasecurity:main Jun 2, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

scanJobAnnotations apply to the Pod only and not the Job
3 participants