Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scanJobAnnotations apply to the Pod only and not the Job #2109

Closed
darkhelmet opened this issue May 28, 2024 · 1 comment · Fixed by #2111
Closed

scanJobAnnotations apply to the Pod only and not the Job #2109

darkhelmet opened this issue May 28, 2024 · 1 comment · Fixed by #2111
Labels
kind/bug Categorizes issue or PR as related to a bug.

Comments

@darkhelmet
Copy link
Contributor

What steps did you take and what happened:

Trying to configure annotations to make botkube ignore the scanning activity. The notifications get noisy for us, and I don't need to hear about Trivy starting up all the time.

What did you expect to happen:

When using the trivyOperator.scanJobAnnotations value when configuring the operator helm chart, I would expect those annotations to apply to the Job resource, given the name.

Anything else you would like to add:

I imagine there is a case where you'd want to configure the Pod and Job annotations separately, so maybe it makes sense to have configuration for both, but applying the scanJobAnnotations to the actual Job resources seems like a good step.

An alternative is we configure botkube to ignore the triv-system namespace we have Trivy installed in, but the annotations should probably work here too.

Environment:

  • Trivy-Operator version (use trivy-operator version): 0.21.1
  • Kubernetes version (use kubectl version): 1.28.9 EKS
  • OS (macOS 10.15, Windows 10, Ubuntu 19.10 etc): N/A
@darkhelmet darkhelmet added the kind/bug Categorizes issue or PR as related to a bug. label May 28, 2024
@chen-keinan
Copy link
Contributor

@darkhelmet could be a nice enhancement, you can pick it up if you have time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants