Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support aria-live attribute #106

Merged

Conversation

nickvergessen
Copy link
Contributor

Fix #105

Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen
Copy link
Contributor Author

Sorry if I made mistakes on the way, I could not find a way to generate toastify-es from toastify or the other way around, so I did the edit in both files manually?!

Copy link
Owner

@apvarun apvarun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@apvarun apvarun merged commit 5b8fe2a into apvarun:master Jul 21, 2022
@nickvergessen nickvergessen deleted the feature/105/support-aria-live-attribute branch July 21, 2022 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve accessibility by defaulting and allowing aria-live
2 participants