Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve accessibility by defaulting and allowing aria-live #105

Closed
nickvergessen opened this issue Jul 20, 2022 · 3 comments · Fixed by #106
Closed

Improve accessibility by defaulting and allowing aria-live #105

nickvergessen opened this issue Jul 20, 2022 · 3 comments · Fixed by #106

Comments

@nickvergessen
Copy link
Contributor

Hi there, greetings from nextcloud-libraries/nextcloud-dialogs#255
We are in the process of doing an A11y validation and one of the remarks was that or errors and messages (which are using toastify) are not read by screen readers.
This can be easily achieved by setting aria-live="polite" on the HTMLElement.

For errors and important information it is even recommended to use aria-live="assertive", however this interrupts whatever is currently being read out by the screenreader, so it should be "opt in" so it can be used for errors and similar stuff, but is not forced for "Your message was posted" kind of messages.

Currently I implemented a PR in our lib which just manipulates the HTMLElement afterwards:
https://github.com/nextcloud/nextcloud-dialogs/pull/622/files

But of course it would be better if the library would allow this directly, so all users of the lib benefit from it.

Are you interested in fixing this and would accept a pull request + publish a new version afterwards?

@apvarun
Copy link
Owner

apvarun commented Jul 20, 2022

Hi @nickvergessen
This is some good stuff. Please do send in a PR for the same. I'll be happy to publish a new version afterwards.

@nickvergessen
Copy link
Contributor Author

Patch in #106

@apvarun
Copy link
Owner

apvarun commented Jul 21, 2022

@nickvergessen New Release v1.12.0 is up

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants