[Governance] proposal metadata from url #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -21,6 +21,25 @@ export function ProposalContent({ | |||
| return null; | |||
| } | |||
|
|
|||
| const [metadata, setMetadata] = useState<any>(null); | |||
There was a problem hiding this comment.
Is it possible to add a type instead of any (e.g. it appears to be an object that has description and execution_script properties)?
| }; | ||
|
|
||
| fetchMetadata(); | ||
| }, []); |
There was a problem hiding this comment.
Should it re-fetch the metadata if metadata_location changes?
There was a problem hiding this comment.
Thanks for the comment! metadata_location comes from the chain so it's probably won't be changed. Although I'll apply the change to be safe.
0xmaayan
reviewed
Jul 25, 2022
| const CODE_LOCATION_PLACEHOLDER = "https://aptoslabs.com/"; | ||
| const TITLE_PLACEHOLDER = "Title -- Lorem ipsum dolor sit amet"; | ||
| const METADATA_LOCATION_PLACEHOLDER = | ||
| "https://mocki.io/v1/32403c87-d5d2-4136-80fd-d639a5d3d7dd"; |
There was a problem hiding this comment.
are we also getting the title from the metadata link? https://mocki.io/v1/32403c87-d5d2-4136-80fd-d639a5d3d7dd has title also
There was a problem hiding this comment.
As mentioned in the PR summary, I'll add the title later to avoid merge conflicts.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To align with change in aptos-labs/aptos-core#2121, this PR display proposal content metadata (description, code) from and external url.
Next step: