[Aptos Framework] Update proposal fields for AptosGovernance to allow more generic metadata #2121
Conversation
movekevin
requested review from
banool,
CapCap,
gregnazario,
0xmaayan and
0xZihan
| metadata_location: String, | ||
| // The hash of the metadata to allow easy verification when a user votes that the metadata hosted at a url is | ||
| // correct. | ||
| metadata_hash: String, |
There was a problem hiding this comment.
Do you want the code hash as well or only the metadata?
There was a problem hiding this comment.
I was thinking this can help people verify if the content at the provided url has been changed after the fact. The code can stay the same for example but description can change. I might be overthinking a bit though - this depends on how much validation we want to do in the CLI.
There was a problem hiding this comment.
Agree. I feel it makes sense for the Title and Description to be flexible but restrict the change of the code. If that's the case can we make the hash a code_hash instead of metadata_hash? Also just brainstorming, maybe we can keep both code_location and metadata_location, so that one is unchangeable and the other is flexible.
There was a problem hiding this comment.
I think we should have a hash for the whole thing for now and make it all immutable, allowing people to change data is a nice to have for later.
There was a problem hiding this comment.
Yes what Daniel said. The code hash (execution_hash) is a separate field and meant for on-chain authorization when the vote is executed/resolved. The metadata hash is more meant for off chain usage to allow users to verify that the metadata such as description, in addition to the code, that they're looking at has not been maliciously altered.
There was a problem hiding this comment.
I see. I missed execution_hash. Thanks for the clarification.
We can also emit an event with the metadata_location and metadata_hash. An indexer can then decide if they want to load and store the metadata content from the provided location/url. |
… more generic metadata
✅ Forge test successForge is land-blocking |
Description
Currently a proposal has code location, title and description. This is not very flexible. This PR changes the fields to be more generic, allowing the metadata to be constructed in dynamically off-chain.
Test Plan
Unit tests.
This change is