[dag] simplify DAGNetworkSender impl

[ibalajiarun]

Description

This PR gets rid of the DAGNetworkSenderImpl and instead makes NetworkSender implement the DAGNetworkSender. To support this, DAGNetworkSender's send_rpc_with_fallbacks now takes in an Arc instead of the self receiver.

Test Plan

[ibalajiarun]

Current dependencies on/for this PR:

• main
  • PR [dag] split fetcher into service and helper struct #9830
    • PR [dag][bugfix] reverse nodes before adding to dag store #9831
      • PR [dag] preliminary state sync implementation #9724
        • PR [dag] broadcast CertifiedNodeMsg with LedgerInfo #9968
          • PR [dag] dag rebootstrap #9967
            • PR [consensus] introduce CommitSignerProvider trait #10006
              • PR [consensus] epoch manager refactoring; dag is coming #9994
                • PR [dag] commit signer #10040
                  • PR [dag] store parent block info in adapter #10041
                  • PR [dag] simplify DAGNetworkSender impl #10042 👈
                  • PR [dag] async message handler support #10055
                  • PR [consensus][dag] dag integration helpers #10056
                  • PR [dag] epoch manager integration; dag is here #10007
        • PR [dag] state sync good case unit test #9832

This comment was auto-generated by Graphite.

[github-actions]

✅ Forge suite compat success on aptos-node-v1.6.2 ==> 0dcc80377ba82a55de9ecb25d294ece5c4cb7801

Compatibility test results for aptos-node-v1.6.2 ==> 0dcc80377ba82a55de9ecb25d294ece5c4cb7801 (PR)
1. Check liveness of validators at old version: aptos-node-v1.6.2
compatibility::simple-validator-upgrade::liveness-check : committed: 4544 txn/s, latency: 7227 ms, (p50: 7800 ms, p90: 10100 ms, p99: 11100 ms), latency samples: 168160
2. Upgrading first Validator to new version: 0dcc80377ba82a55de9ecb25d294ece5c4cb7801
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 1831 txn/s, latency: 15801 ms, (p50: 19900 ms, p90: 22000 ms, p99: 22500 ms), latency samples: 91560
3. Upgrading rest of first batch to new version: 0dcc80377ba82a55de9ecb25d294ece5c4cb7801
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 1410 txn/s, submitted: 1411 txn/s, expired: 1 txn/s, latency: 16303 ms, (p50: 18300 ms, p90: 22200 ms, p99: 24600 ms), latency samples: 90254
4. upgrading second batch to new version: 0dcc80377ba82a55de9ecb25d294ece5c4cb7801
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 3333 txn/s, latency: 9233 ms, (p50: 9600 ms, p90: 13200 ms, p99: 13600 ms), latency samples: 140000
5. check swarm health
Compatibility test for aptos-node-v1.6.2 ==> 0dcc80377ba82a55de9ecb25d294ece5c4cb7801 passed
Test Ok

• Grafana dashboard
• Humio Logs
• Test runner output
• Test run is land-blocking

[github-actions]

✅ Forge suite realistic_env_max_load success on 0dcc80377ba82a55de9ecb25d294ece5c4cb7801

two traffics test: inner traffic : committed: 6175 txn/s, latency: 6342 ms, (p50: 6000 ms, p90: 8100 ms, p99: 11100 ms), latency samples: 2674080
two traffics test : committed: 100 txn/s, latency: 3134 ms, (p50: 3100 ms, p90: 3800 ms, p99: 7000 ms), latency samples: 1820
Latency breakdown for phase 0: ["QsBatchToPos: max: 0.238, avg: 0.213", "QsPosToProposal: max: 0.190, avg: 0.162", "ConsensusProposalToOrdered: max: 0.662, avg: 0.636", "ConsensusOrderedToCommit: max: 0.510, avg: 0.490", "ConsensusProposalToCommit: max: 1.161, avg: 1.126"]
Max round gap was 1 [limit 4] at version 1380707. Max no progress secs was 3.471564 [limit 10] at version 1380707.
Test Ok

• Grafana dashboard
• Humio Logs
• Test runner output
• Test run is land-blocking

[github-actions]

✅ Forge suite framework_upgrade success on aptos-node-v1.5.1 ==> 0dcc80377ba82a55de9ecb25d294ece5c4cb7801

Compatibility test results for aptos-node-v1.5.1 ==> 0dcc80377ba82a55de9ecb25d294ece5c4cb7801 (PR)
Upgrade the nodes to version: 0dcc80377ba82a55de9ecb25d294ece5c4cb7801
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 5029 txn/s, latency: 6577 ms, (p50: 6700 ms, p90: 10200 ms, p99: 11400 ms), latency samples: 181060
5. check swarm health
Compatibility test for aptos-node-v1.5.1 ==> 0dcc80377ba82a55de9ecb25d294ece5c4cb7801 passed
Test Ok

• Grafana dashboard
• Humio Logs
• Test runner output
• Test run is land-blocking