-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Basic ancestry functionality #143
Basic ancestry functionality #143
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #143 +/- ##
===========================================
+ Coverage 93.44% 93.52% +0.07%
===========================================
Files 8 8
Lines 1540 1559 +19
Branches 273 274 +1
===========================================
+ Hits 1439 1458 +19
Misses 54 54
Partials 47 47
Continue to review full report at Codecov.
|
@arvkevi I think we're close with getting the initial tests working. However,
However, that defeats the simplicity of just |
Thank you for hacking on this PR, Andrew! I cut a release to ezancestry that supports 3.7, which is why I triggered the build yesterday w/ an empty commit. I am confused as to why this is taking so long to resolve dependencies. I'll spend some more time with it. |
Hi Kevin, same here. FYI, I tried running the |
I did some more testing with Hopefully that helps speed the troubleshooting along. 🙂 |
Thanks, Andrew. I will cut a new release this weekend with a fix for the filenames. I'll also setup my own ci in ezancestry so we don't languish on this branch. Thanks for being so patient with this. |
I think I fixed the issue with the new release. The new errors are likely due newly trained models in the release. We can probably just update the assert value. |
I think we're good @arvkevi! What are your thoughts on also exposing the raw |
@apriha I think that's a good idea. I will put together some documentation with column descriptions. |
I'll leave this here and feel free to modify and incorporate wherever you like. Populations described below are defined here.
'
|
@arvkevi updates incorporated. Please let me know what you think... If you agree, I think it's ready to merge. Thanks again for developing this awesome capability! |
LGTM @apriha, thank you for all your hard work on this PR! |
This PR adds basic functionality to predict genetic ancestry using ezancestry. @apriha please feel free to make suggestions/direct edits as you see fit, this is just to get the concept moving forward. Here's how a user could utilize this functionality from
snps
.