Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat variable specifications #1301
Feat variable specifications #1301
Changes from all commits
8a78c41
f8ec933
7e72391
10b48f9
84bb17b
7984f38
ac850e6
1d050aa
bfa142d
21f3d94
c95befe
557dbba
cedc1af
15b30c7
a5749c7
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you try this flow?
I think template without specification is okay - it can take default value
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We automatically select the base specification on load, see https://github.com/appwrite/console/pull/1301/files/cedc1af747e9c1dfb3a2d4190f4a10e6e6ff99f1#diff-b1d4bcc01b5994925abf0fc4b457c6a8e50804765145f043d9c3ffe8a4b062d6R48-R51
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need PR for CLI as well, so CLI stores and sets this new attribute properly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Created the PR for CLI Here: appwrite/sdk-generator#1025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Below this, in HTML, line 93, it says
Runtime
as title of the card. We might want to rename this to "Settings" too, possibly.Also important to understand how specs behave during build. Is gb-hours increased properly? Is the limit used properly?
Best to have it explained in Console, or docs.