Feat variable specifications #1301
Conversation
Feat implement runtime controls
# Conflicts: # package-lock.json # package.json
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
The preview deployment is ready. 🟢 Open Preview | Open Build Logs Last updated at: 2024-08-23 03:41:04 CET |
# Conflicts: # package.json # src/routes/(console)/project-[project]/functions/+layout.ts # src/routes/(console)/project-[project]/functions/function-[function]/settings/updateRuntime.svelte # src/routes/(console)/project-[project]/functions/store.ts
# Conflicts: # pnpm-lock.yaml
# Conflicts: # package-lock.json # pnpm-lock.yaml
2024-12-17.19-04-54.mp42024-12-18.12-37-09.mp4 |
| if (!$templateConfig.specification) { | ||
| throw new Error('Please select a specification.'); | ||
| } |
There was a problem hiding this comment.
Can you try this flow?
I think template without specification is okay - it can take default value
There was a problem hiding this comment.
We automatically select the base specification on load, see https://github.com/appwrite/console/pull/1301/files/cedc1af747e9c1dfb3a2d4190f4a10e6e6ff99f1#diff-b1d4bcc01b5994925abf0fc4b457c6a8e50804765145f043d9c3ffe8a4b062d6R48-R51
| ); | ||
| await invalidate(Dependencies.FUNCTION); | ||
| addNotification({ | ||
| message: 'Runtime has been updated', | ||
| message: 'Runtime settings have been updated', |
There was a problem hiding this comment.
Below this, in HTML, line 93, it says Runtime as title of the card. We might want to rename this to "Settings" too, possibly.
Also important to understand how specs behave during build. Is gb-hours increased properly? Is the limit used properly?
Best to have it explained in Console, or docs.
| @@ -51,11 +67,12 @@ | |||
| $func.providerRepositoryId || undefined, | |||
| $func.providerBranch || undefined, | |||
| $func.providerSilentMode || undefined, | |||
| $func.providerRootDirectory || undefined | |||
| $func.providerRootDirectory || undefined, | |||
There was a problem hiding this comment.
We need PR for CLI as well, so CLI stores and sets this new attribute properly.
There was a problem hiding this comment.
Created the PR for CLI Here: appwrite/sdk-generator#1025
What does this PR do?
This PR implements variable specifications into the console.
Have you read the Contributing Guidelines on issues?
Yes