Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix url evaluation #38380

Merged
merged 1 commit into from
Dec 27, 2024
Merged

fix: fix url evaluation #38380

merged 1 commit into from
Dec 27, 2024

Conversation

alex-golovanov
Copy link
Contributor

@alex-golovanov alex-golovanov commented Dec 26, 2024 •
edited by github-actions bot
Loading

Description

Fixes API_Edit_spec.js

Fixes #38135

Automation

/ok-to-test tags="@tag.AccessControl"

🔍 Cypress test results

Tip

🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/12507336996
Commit: 7ff5552
Cypress dashboard.
Tags: @tag.AccessControl
Spec:

Thu, 26 Dec 2024 21:27:58 UTC

Communication

Should the DevRel and Marketing teams inform users about this change?

  • Yes
  • No

Summary by CodeRabbit

  • Bug Fixes
    • Adjusted the test case for URL field interaction by removing the Enter key action after clicking, streamlining the validation process.

@coderabbitai coderabbitai
Copy link
Contributor

coderabbitai bot commented Dec 26, 2024 •
edited
Loading

Walkthrough

The pull request introduces a minor modification in a Cypress test suite for API functionality. Specifically, in the test case "5. Shows evaluated value pane when url field is focused," a line of code that typed the Enter key after clicking an element has been removed. This change slightly adjusts the control flow of the UI interaction test without altering the overall test logic or validation process.

Changes

File Change Summary
app/client/cypress/e2e/Regression/ServerSide/ApiTests/API_Edit_spec.js Removed Enter key typing action after element click in a specific test case

Assessment against linked issues

Objective Addressed Explanation
Fix query tab scrollbar position [#38135] ❓ No direct connection to scrollbar positioning observed in this change

Possibly related PRs

Suggested labels

Bug, ok-to-test, Query Forms, IDE Product

Suggested reviewers

  • NandanAnantharamu
  • ApekshaBhosale

Poem

A Cypress test, once verbose with might,
Enter key removed, a subtle delight
UI interactions, now lean and clean
A tiny change in the testing scene
Code refinement, oh so bright! 🧪✨

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 6905aa9 and 7ff5552.

📒 Files selected for processing (1)
  • app/client/cypress/e2e/Regression/ServerSide/ApiTests/API_Edit_spec.js (1 hunks)
✅ Files skipped from review due to trivial changes (1)
  • app/client/cypress/e2e/Regression/ServerSide/ApiTests/API_Edit_spec.js

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions github-actions bot added Bug Something isn't working IDE Pod Issues that new developers face while exploring the IDE IDE Product Issues related to the IDE Product Low An issue that is neither critical nor breaks a user flow QA Needs QA attention QA Pod Issues under the QA Pod Task A simple Todo labels Dec 26, 2024
@alex-golovanov alex-golovanov added the ok-to-test Required label for CI label Dec 26, 2024
@alex-golovanov
Copy link
Contributor Author

/ci-test-limit-count run_count=1 update_snapshot=true specs_to_run=cypress/e2e/Regression/ServerSide/ApiTests/API_Edit_spec.js

@github-actions GitHub Actions
Copy link

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/12503862745.
Cypress dashboard
PR: #38380 .

@alex-golovanov
Copy link
Contributor Author

/ci-test-limit-count run_count=1 update_snapshot=true specs_to_run=cypress/e2e/Regression/ClientSide/VisualTests/JSEditorIndent_spec.js

@github-actions GitHub Actions
Copy link

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/12503879298.
Cypress dashboard
PR: #38380 .

@sagar-qa007
Copy link
Contributor

/ci-test-limit-count run_count=1 update_snapshot=false specs_to_run=cypress/e2e/Regression/ServerSide/ApiTests/API_Edit_spec.js runId=12503879298

@github-actions GitHub Actions
Copy link

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/12504710532.
Cypress dashboard
PR: #38380 .

@alex-golovanov alex-golovanov removed the ok-to-test Required label for CI label Dec 26, 2024
@alex-golovanov
Copy link
Contributor Author

/ci-test-limit-count run_count=1 update_snapshot=true specs_to_run=cypress/e2e/Regression/ClientSide/VisualTests/JSEditorIndent_spec.js

@github-actions GitHub Actions
Copy link

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/12505130653.
Cypress dashboard
PR: #38380 .

@alex-golovanov alex-golovanov added ok-to-test Required label for CI and removed ok-to-test Required label for CI labels Dec 26, 2024
@sagar-qa007 sagar-qa007 merged commit 257828b into release Dec 27, 2024
110 of 112 checks passed
@sagar-qa007 sagar-qa007 deleted the fix/38135-cypress-fix branch December 27, 2024 03:14
NandanAnantharamu pushed a commit that referenced this pull request Dec 27, 2024
@alex-golovanov
fix: fix url evaluation (#38380)
d3f9b5d 
## Description
Fixes API_Edit_spec.js

Fixes #38135 

## Automation

/ok-to-test tags="@tag.AccessControl"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/12507336996>
> Commit: 7ff5552
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=12507336996&attempt=2"
target="_blank">Cypress dashboard</a>.
> Tags: `@tag.AccessControl`
> Spec:
> <hr>Thu, 26 Dec 2024 21:27:58 UTC
<!-- end of auto-generated comment: Cypress test results  -->


## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [ ] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **Bug Fixes**
- Adjusted the test case for URL field interaction by removing the Enter
key action after clicking, streamlining the validation process.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
@coderabbitai coderabbitai bot mentioned this pull request Dec 27, 2024
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sagar-qa007 sagar-qa007 sagar-qa007 approved these changes

@ApekshaBhosale ApekshaBhosale Awaiting requested review from ApekshaBhosale ApekshaBhosale is a code owner

Assignees
No one assigned
Labels
Bug Something isn't working IDE Pod Issues that new developers face while exploring the IDE IDE Product Issues related to the IDE Product Low An issue that is neither critical nor breaks a user flow ok-to-test Required label for CI QA Pod Issues under the QA Pod QA Needs QA attention Task A simple Todo
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix query tab scrollbar position
2 participants
@alex-golovanov @sagar-qa007