fix: Minor changes in Datasource and API

[hetunandu]

Description

Fixes issues introduced in #38317 and #38321

Automation

/ok-to-test tags="@tag.IDE"

🔍 Cypress test results

Tip

🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/12500529563
Commit: 92a1b59
Cypress dashboard.
Tags: @tag.IDE
Spec:

---

Thu, 26 Dec 2024 06:56:12 UTC

Communication

Should the DevRel and Marketing teams inform users about this change?

• Yes
• No

Summary by CodeRabbit

• New Features

  • Added a call-to-action message for users when no datasources are available, encouraging them to "Bring your data."
  • Introduced options for starting new applications, including templates, scratch, or with data, enhancing user guidance during app creation.

• Bug Fixes

  • Updated button text in the data side pane to reflect the new call-to-action message.

• Chores

  • Improved testability of the CommonEditorForm component by adding a data-testid attribute.
  • Updated import paths for better module resolution.

[coderabbitai]

Walkthrough

This pull request introduces modifications to multiple files in the client-side application, focusing on enhancing user interface elements and messaging. The changes include adding a test ID attribute to a form component, introducing new constants for datasource and app creation messaging, and updating import paths. These modifications aim to improve testability, user guidance, and potentially streamline the application's onboarding experience.

Changes

File	Change Summary
app/client/src/PluginActionEditor/components/PluginActionForm/components/CommonEditorForm/CommonEditorForm.tsx	Added data-testid attribute to Styled.Tabs with optional props.dataTestId
app/client/src/ce/constants/messages.ts	Added multiple constants for datasource blank state and app creation messaging
app/client/src/pages/Editor/IDE/LeftPane/DataSidePane.tsx	Updated import for DATASOURCE_BLANK_STATE_CTA and changed import path for INTEGRATION_TABS

Possibly related PRs

• chore: Handling the updation of action name in the plugin action toolbar #36560: Changes to PluginActionNameEditor component
• chore: Create query selector #37018: Updates to createTempDatasourceFromForm function
• fix: datasource name not reflecting in schema pane #37131: Datasource name schema pane reflection
• chore: Updating the UI for save and edit datasource button in API editor #37302: UI updates for save and edit datasource buttons
• fix: Updating the logic for datasource selector to fox the client build failure on prod #38107: Enhancing Datasource component with plugin prop
• chore: Cherry picking fix for client build failure #38109: Further Datasource component modifications
• chore: Fixing the top padding for queries and JS empty state to match UI segment empty state #38365: Improvements to empty state UI for queries and JS objects

Suggested labels

Bug, Enhancement, IDE Product, Task, IDE Pod, ok-to-test

Suggested reviewers

• albinAppsmith
• ApekshaBhosale

Poem

🚀 Code whispers of change, so bright
Tabs and messages taking flight
Testability dancing with grace
A developer's smile lights the space
New paths unfold, creativity gleams! 🌟

Tip

CodeRabbit's docstrings feature is now available as part of our Early Access Program! Simply use the command @coderabbitai generate docstrings to have CodeRabbit automatically generate docstrings for your pull request. We would love to hear your feedback on Discord.

---

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 3c802d9 and 92a1b59.

📒 Files selected for processing (3)

• app/client/src/PluginActionEditor/components/PluginActionForm/components/CommonEditorForm/CommonEditorForm.tsx (1 hunks)
• app/client/src/ce/constants/messages.ts (1 hunks)
• app/client/src/pages/Editor/IDE/LeftPane/DataSidePane.tsx (2 hunks)

🔇 Additional comments (5)

app/client/src/PluginActionEditor/components/PluginActionForm/components/CommonEditorForm/CommonEditorForm.tsx (1)

55-56: Preserve optional attribute usage
Addition of the data-testid prop is a neat way to improve testing.

app/client/src/pages/Editor/IDE/LeftPane/DataSidePane.tsx (3)

20-20: Added new CTA import
Nice job incorporating the new call-to-action constant.

---

25-25: Import path update
Shifting to the absolute constants/routes import is consistent with your overall approach.

---

103-103: Refined empty-state button text
Switching the button text to DATASOURCE_BLANK_STATE_CTA aligns with the new branding style.

app/client/src/ce/constants/messages.ts (1)

2310-2310: New CTA constant introduced
DATASOURCE_BLANK_STATE_CTA effectively reflects the rebranded empty-state messaging.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.