fix:Widget Column test case fix

[sagar-qa007]

Description

Column name updates.

Fixes #Issue Number
or
Fixes Issue URL

Warning

If no issue exists, please create an issue first, and check with the maintainers if the issue is valid.

Automation

/ok-to-test tags="@tag.Widget"

🔍 Cypress test results

Tip

🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/12235074532
Commit: 245d0f2
Cypress dashboard.
Tags: @tag.Widget
Spec:

---

Mon, 09 Dec 2024 13:04:29 UTC

Communication

Should the DevRel and Marketing teams inform users about this change?

• Yes
• No

Summary by CodeRabbit

• Bug Fixes

  • Updated widget property navigation test cases to reflect changes in widget properties.

• Chores

  • Modified the list of limited tests to replace an outdated test entry with a new focus on widget property navigation.

[sagar-qa007]

/ci-test-limit-count run_count=20 runId=12232063661

[coderabbitai]

Caution

Review failed

The head commit changed during the review from 3cff169 to 245d0f2.

Walkthrough

The pull request modifies the Cypress test cases for widget property navigation, specifically updating the properties being tested in the Widget_property_navigation_spec.ts file. The focus shifts from "id" to "imdb_id" for the table widget validation, reflecting changes in the application. Additionally, the limited-tests.txt file is updated to replace the previous test entry with the new widget property navigation spec, maintaining the overall structure of limited tests.

Changes

File Path	Change Summary
app/client/cypress/e2e/Regression/ClientSide/Debugger/Widget_property_navigation_spec.ts	Updated test cases for widget property navigation, changing "id" to "imdb_id" in assertions.
app/client/cypress/limited-tests.txt	Replaced entry for Fork_Template_spec.js with Widget_property_navigation_spec.ts.

Possibly related issues

• Fix Widget_property_navigation_spec.ts and PropertyControl_spec.ts #38022: This issue aims to fix Widget_property_navigation_spec.ts, which is directly addressed by the modifications in this PR.

Possibly related PRs

• test: PartialExport_Widgets_spec - updated test validation logic #33371: Relates to updates in widget property navigation tests, similar to changes in PartialExport_Widgets_spec.
• test: Updated file name for remove duplicate #34821: Connects with updates in the TableV2Filter2_2_Spec, which also deals with table widget properties.
• fix: Fixes currentRow calculation logic in table(property pane) #35390: Involves changes in the TableV2_PropertyPane_2_spec, focusing on validating properties of table widgets.
• fix: Fixed Bug29566 spec with list widget #36260: Relevant to updates in the Bug29566_Spec, which tests widget functionalities.
• fix: Inline editing flaky test fix #36366: Connects with the Inline_editing_2_spec, which deals with widget interactions.
• test: fix tabs skipped test CE #37023: Involves testing widget properties in the Tabs_2_spec.
• fix: Widget property test case fix #38001: Directly relates to updates in Widget_property_navigation_spec.ts, which tests widget properties.

Suggested labels

ok-to-test, Test, Widgets Product, Production, Needs Triaging

Suggested reviewers

• ApekshaBhosale
• NandanAnantharamu

🎉 In the realm of code, where tests do thrive,
Widget properties dance, keeping tests alive.
From "id" to "imdb_id", a shift we embrace,
With Cypress we navigate, in this testing race.
Limited tests updated, the focus now clear,
In the world of widgets, we have nothing to fear! 🎉

---

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[github-actions]

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/12233426820.
Cypress dashboard
PR: #38045.

[coderabbitai]

Actionable comments posted: 1

🧹 Outside diff range and nitpick comments (1)

app/client/cypress/e2e/Regression/ClientSide/Debugger/Widget_property_navigation_spec.ts (1)

Line range hint 175-179: Use constants for assertion messages.

Store the column name "imdb_id" in a constant to maintain consistency and make updates easier.

+const COLUMN_NAME = "imdb_id";
// ...
-_.agHelper.GetNAssertContains(_.propPane._paneTitle, "imdb_id");
+_.agHelper.GetNAssertContains(_.propPane._paneTitle, COLUMN_NAME);

📜 Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between 7184101 and 34a57df.

📒 Files selected for processing (2)

• app/client/cypress/e2e/Regression/ClientSide/Debugger/Widget_property_navigation_spec.ts (1 hunks)
• app/client/cypress/limited-tests.txt (1 hunks)

✅ Files skipped from review due to trivial changes (1)

• app/client/cypress/limited-tests.txt

🧰 Additional context used

📓 Path-based instructions (1)

app/client/cypress/e2e/Regression/ClientSide/Debugger/Widget_property_navigation_spec.ts (1)

Pattern app/client/cypress/**/**.*: Review the following e2e test code written using the Cypress test library. Ensure that:

• Follow best practices for Cypress code and e2e automation.
• Avoid using cy.wait in code.
• Avoid using cy.pause in code.
• Avoid using agHelper.sleep().
• Use locator variables for locators and do not use plain strings.
• Use data-* attributes for selectors.
• Avoid Xpaths, Attributes and CSS path.
• Avoid selectors like .btn.submit or button[type=submit].
• Perform logins via API with LoginFromAPI.
• Perform logout via API with LogOutviaAPI.
• Perform signup via API with SignupFromAPI.
• Avoid using it.only.
• Avoid using after and aftereach in test cases.
• Use multiple assertions for expect statements.
• Avoid using strings for assertions.
• Do not use duplicate filenames even with different paths.
• Avoid using agHelper.Sleep, this.Sleep in any file in code.

🔇 Additional comments (2)

app/client/cypress/e2e/Regression/ClientSide/Debugger/Widget_property_navigation_spec.ts (2)

167-171: 🛠️ Refactor suggestion

Avoid using hardcoded waits.

The test uses WaitUntilTableLoad before interacting with the table. Consider using Cypress's built-in retry-ability with assertions instead.

-_.table.WaitUntilTableLoad(0, 0, "v2");
+cy.get('[data-cy="table-widget"]')
+  .should('be.visible')
+  .and('have.length.gt', 0);

Likely invalid or redundant comment.

---

Line range hint 1-182: Verify test coverage for column name changes.

The test case focuses on validating the regex functionality but should also verify the column name change impact.

[github-actions]

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/12233426820.
Cypress dashboard: Click here!
The following are new failures, please fix them before merging the PR:
To know the list of identified flaky tests - Refer here

***** Repeat Run Summary ***** Total Tests with repeat: 140 Total Passed: 140 Total Failed: 0 Total Skipped: 0 *****************************

[NandanAnantharamu]

Lgtm