fix: Inline editing flaky test fix #36366

sagar-qa007 · 2024-09-17T09:23:19Z

Description

Root Cause Analysis (RCA):
The updateCodeInput function was identified as a source of flakiness due to improper execution. Additionally, the SaveLocalStorageCache caused issues by retaining the reset button after the 6th test case, resulting in a duplicate button in the 7th test case, which led to test failures.

Solution:
Replaced updateCodeInput with EnterJSContext from agHelper for more reliable execution. For the second flaky step, a new page was created, and a table with relevant data was added. This resolved the issue without requiring significant changes to the test case or workflow.

Fixes #36365

Automation

/ok-to-test tags="@tag.ImportExport"

🔍 Cypress test results

Tip

🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/10940196158
Commit: 32d1be4
Cypress dashboard.
Tags: @tag.ImportExport
Spec:

Thu, 19 Sep 2024 12:01:32 UTC

Communication

Should the DevRel and Marketing teams inform users about this change?

Yes
No

Summary by CodeRabbit

Bug Fixes
- Adjusted the inline editing test suite for the table widget to improve state management between tests.
New Features
- Updated the limited tests to focus on inline editing functionality, enhancing testing priorities for the Table V2 widget.
- Introduced new properties in the widget locators to enhance UI interactions, including selectors for various controls and elements within the property pane and cell editing functionalities.
- Added a new JavaScript toggle selector to facilitate interactions in tests.

coderabbitai · 2024-09-17T09:23:27Z

Walkthrough

The pull request enhances the test suite for the inline editing functionality of the Table V2 widget. It introduces a new test case for multi-row updates, replaces a test file in limited tests to focus on inline editing, and adds new locators for UI elements in the widget. Additionally, it updates the PROPERTY_SELECTOR object to include a new JavaScript toggle selector, thus broadening the testing capabilities.

Changes

Files	Change Summary
`app/client/cypress/e2e/Regression/ClientSide/Widgets/TableV2/Inline_editing_2_spec.js`	Expanded test case for multi-row updates; added import for `PageList`; improved `onClick` property setup.
`app/client/cypress/limited-tests.txt`	Replaced `Fork_Template_spec.js` with `Inline_editing_2_spec.js` for limited tests.
`app/client/cypress/locators/WidgetLocators.ts`	Added `jsToggle` property to `PROPERTY_SELECTOR` for JavaScript toggle element.
`app/client/cypress/locators/Widgets.json`	Added new properties: `propertyPaneSaveButton`, `firstEditInput`, `cellControlSwitch`, and `propertyControlLabel`.

Assessment against linked issues

Objective	Addressed	Explanation
Fix inline_editing_2_spec test (#36365)	✅

Possibly related PRs

feat: Allow table search to include label and value for tables with select column type #36061: Enhances test specifications for the TableV2 component, related to inline editing functionality.
chore: fix select1 spec #36228: Modifies the Select1_spec.ts file, aligning with the focus on inline editing features in the main PR.
test: fix failing table filter spec by rearranging steps. #36303: Addresses the test specification for the TableV2 filter, relevant to the overall testing strategy for the TableV2 widget discussed in the main PR.

Suggested labels

Test, Widgets & Accelerators Pod, Integrations Pod General

Suggested reviewers

ApekshaBhosale
sagar-qa007
jsartisan

In the realm of code, a change takes flight,
Tests now dance in the soft moonlight.
Inline editing, a focus anew,
With local storage, we bid adieu.
A test suite refined, let’s cheer and sing,
For every line of code, joy it brings! 🎉

Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
-- I pushed a fix in commit <commit_id>, please review it.
-- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
-- @coderabbitai generate unit testing code for this file.
-- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
-- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
-- @coderabbitai read src/utils.ts and generate unit testing code.
-- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
-- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

sagar-qa007 · 2024-09-17T09:23:43Z

/ci-test-limit-count run_count=20

github-actions · 2024-09-17T09:24:11Z

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/10900231806.
Cypress dashboard
PR: #36366.

github-actions · 2024-09-17T11:18:57Z

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/10900231806.
Cypress dashboard: Click here!
The following are new failures, please fix them before merging the PR:
To know the list of identified flaky tests - Refer here

***** Repeat Run Summary ***** Total Tests with repeat: 140 Total Passed: 140 Total Failed: 0 Total Skipped: 0 *****************************

app/client/cypress/e2e/Regression/ClientSide/Widgets/TableV2/Inline_editing_2_spec.js

sagar-qa007 · 2024-09-17T15:42:08Z

/ci-test-limit-count run_count=25

github-actions · 2024-09-17T15:42:41Z

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/10906464883.
Cypress dashboard
PR: #36366.

github-actions · 2024-09-17T17:58:10Z

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/10906464883.
Cypress dashboard url: Click here!
All Cypress tests have passed 🎉🎉🎉

***** Repeat Run Summary ***** Total Tests with repeat: 175 Total Passed: 168 Total Failed: 7 Total Skipped: 0 *****************************

sagar-qa007 · 2024-09-18T17:40:59Z

/ci-test-limit-count run_count=25

github-actions · 2024-09-18T17:41:32Z

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/10927356629.
Cypress dashboard
PR: #36366.

github-actions · 2024-09-18T20:08:18Z

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/10927356629.
Cypress dashboard: Click here!
The following are new failures, please fix them before merging the PR:
To know the list of identified flaky tests - Refer here

***** Repeat Run Summary ***** Total Tests with repeat: 175 Total Passed: 175 Total Failed: 0 Total Skipped: 0 *****************************

app/client/cypress/e2e/Regression/ClientSide/Widgets/TableV2/Inline_editing_2_spec.js

sagar-qa007 · 2024-09-19T06:57:38Z

/ci-test-limit-count run_count=25

github-actions · 2024-09-19T06:58:13Z

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/10935993873.
Cypress dashboard
PR: #36366.

github-actions · 2024-09-19T09:26:49Z

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/10935993873.
Cypress dashboard: Click here!
The following are new failures, please fix them before merging the PR:
To know the list of identified flaky tests - Refer here

***** Repeat Run Summary ***** Total Tests with repeat: 175 Total Passed: 175 Total Failed: 0 Total Skipped: 0 *****************************

app/client/cypress/limited-tests.txt

sagar-qa007 · 2024-09-19T11:38:25Z

@ApekshaBhosale Changes are reverted for limited test. Please review now.

## Description EE PR: [Appsmith EE Pull Request appsmithorg#5158](https://github.com/appsmithorg/appsmith-ee/pull/5158) Root Cause Analysis (RCA): The `updateCodeInput` function was identified as a source of flakiness due to improper execution. Additionally, the `SaveLocalStorageCache` caused issues by retaining the reset button after the 6th test case, resulting in a duplicate button in the 7th test case, which led to test failures. Solution: Replaced `updateCodeInput` with `EnterJSContext` from `agHelper` for more reliable execution. For the second flaky step, a new page was created, and a table with relevant data was added. This resolved the issue without requiring significant changes to the test case or workflow. Fixes #`36365` ## Automation /ok-to-test tags="@tag.ImportExport" ### 🔍 Cypress test results  > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/10940196158> > Commit: 32d1be4 > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=10940196158&attempt=1" target="_blank">Cypress dashboard</a>. > Tags: `@tag.ImportExport` > Spec: > <hr>Thu, 19 Sep 2024 12:01:32 UTC  ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [x] No  ## Summary by CodeRabbit ## Summary by CodeRabbit - **Bug Fixes** - Adjusted the inline editing test suite for the table widget to improve state management between tests. - **New Features** - Updated the limited tests to focus on inline editing functionality, enhancing testing priorities for the Table V2 widget. - Introduced new properties in the widget locators to enhance UI interactions, including selectors for various controls and elements within the property pane and cell editing functionalities. - Added a new JavaScript toggle selector to facilitate interactions in tests.

Inline editing fix

7ab6847

sagar-qa007 requested a review from ApekshaBhosale as a code owner September 17, 2024 09:23

sagar-qa007 added the ok-to-test Required label for CI label Sep 17, 2024

github-actions bot added the Bug Something isn't working label Sep 17, 2024

sagar-qa007 added 2 commits September 17, 2024 16:59

Merge remote-tracking branch 'origin/release' into fix/inlinefailedcase

71849e9

reverted test case

fa07816

sagar-qa007 added ok-to-test Required label for CI and removed ok-to-test Required label for CI labels Sep 17, 2024

ApekshaBhosale requested changes Sep 17, 2024

View reviewed changes

app/client/cypress/e2e/Regression/ClientSide/Widgets/TableV2/Inline_editing_2_spec.js Outdated Show resolved Hide resolved

testing another fix

87630ec

unused import remove

922f300

sagar-qa007 added 3 commits September 18, 2024 23:01

Fix the case

9c8ae31

Reverted some changes

b87e5a2

Reverted click outside

19d60c1

revert limited changes

0b84fd1

ApekshaBhosale requested changes Sep 19, 2024

View reviewed changes

app/client/cypress/e2e/Regression/ClientSide/Widgets/TableV2/Inline_editing_2_spec.js Outdated Show resolved Hide resolved

sagar-qa007 added 3 commits September 19, 2024 12:18

Locator update

cc41e00

Prettier

eb88d7c

Ran limited test

c659f76

ApekshaBhosale requested changes Sep 19, 2024

View reviewed changes

app/client/cypress/limited-tests.txt Outdated Show resolved Hide resolved

reverted changes

32d1be4

yatinappsmith approved these changes Sep 20, 2024

View reviewed changes

yatinappsmith merged commit 1cf043c into release Sep 20, 2024
42 checks passed

yatinappsmith deleted the fix/inlinefailedcase branch September 20, 2024 07:14

This was referenced Oct 7, 2024

test: Update Inline_editing_3_spec.js to include expected JSON parsing #36721

Merged

fix: Focus retention on inputs #36770

Merged

fix: Improve conditional rendering in ChartWidget #36806

Merged

This was referenced Oct 17, 2024

chore: decouple widget-config.json from main chunk #36924

Merged

test: fix tabs skipped test CE #37023

Merged

coderabbitai bot mentioned this pull request Dec 9, 2024

fix:Widget Column test case fix #38045

Merged

2 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: Inline editing flaky test fix #36366

fix: Inline editing flaky test fix #36366

sagar-qa007 commented Sep 17, 2024 •

edited by github-actions bot

Loading

coderabbitai bot commented Sep 17, 2024 •

edited

Loading

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

Documentation and Community

sagar-qa007 commented Sep 17, 2024

github-actions bot commented Sep 17, 2024

github-actions bot commented Sep 17, 2024

sagar-qa007 commented Sep 17, 2024

github-actions bot commented Sep 17, 2024

github-actions bot commented Sep 17, 2024

sagar-qa007 commented Sep 18, 2024

github-actions bot commented Sep 18, 2024

github-actions bot commented Sep 18, 2024

sagar-qa007 commented Sep 19, 2024

github-actions bot commented Sep 19, 2024

github-actions bot commented Sep 19, 2024

sagar-qa007 commented Sep 19, 2024

fix: Inline editing flaky test fix #36366

fix: Inline editing flaky test fix #36366

Conversation

sagar-qa007 commented Sep 17, 2024 • edited by github-actions bot Loading

Description

Automation

🔍 Cypress test results

Communication

Summary by CodeRabbit

Summary by CodeRabbit

coderabbitai bot commented Sep 17, 2024 • edited Loading

Walkthrough

Changes

Assessment against linked issues

Possibly related PRs

Suggested labels

Suggested reviewers

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

Documentation and Community

sagar-qa007 commented Sep 17, 2024

github-actions bot commented Sep 17, 2024

github-actions bot commented Sep 17, 2024

sagar-qa007 commented Sep 17, 2024

github-actions bot commented Sep 17, 2024

github-actions bot commented Sep 17, 2024

sagar-qa007 commented Sep 18, 2024

github-actions bot commented Sep 18, 2024

github-actions bot commented Sep 18, 2024

sagar-qa007 commented Sep 19, 2024

github-actions bot commented Sep 19, 2024

github-actions bot commented Sep 19, 2024

sagar-qa007 commented Sep 19, 2024

sagar-qa007 commented Sep 17, 2024 •

edited by github-actions bot

Loading

coderabbitai bot commented Sep 17, 2024 •

edited

Loading